fix(slash-menu): better overflow behavior (BLO-1192) - #2909
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Mantine suggestion menu now has a 350px maximum width, vertical scrolling, reduced padding, flexible non-shrinking item heights, and wrapping constraints for long titles and subtitles. ChangesSuggestion Menu Layout
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/mantine/src/blocknoteStyles.css`:
- Around line 333-334: Update the fixed width declaration in the relevant menu
style to cap its width at the available containing-block or viewport width,
while retaining the 350px maximum on wider screens. Ensure long content can wrap
without causing horizontal overflow on narrow viewports.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2f721d62-75d2-48c1-b0e1-a2621cd4c791
⛔ Files ignored due to path filters (3)
tests/src/end-to-end/theming/__screenshots__/theming.test.tsx/dark-slash-menu-chromium-linux.pngis excluded by!**/*.pngtests/src/end-to-end/theming/__screenshots__/theming.test.tsx/dark-slash-menu-firefox-linux.pngis excluded by!**/*.pngtests/src/end-to-end/theming/__screenshots__/theming.test.tsx/dark-slash-menu-webkit-linux.pngis excluded by!**/*.png
📒 Files selected for processing (1)
packages/mantine/src/blocknoteStyles.css
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
|
nperez0111
approved these changes
Aug 3, 2026
nperez0111
changed the title
YousefED
added a commit
that referenced
this pull request
Aug 31, 2026
#2909 changed `.bn-suggestion-menu-item` from `height: 52px` to `min-height: 52px` so items could grow to fit wrapped text. But that rule also matches the small variant, which opted out via `height: fit-content` - which overrode the old fixed `height` and does nothing against a `min-height`. Small items therefore rendered at exactly the same 52px as full-size ones, leaving `size: "small"` as a font-size change and a hidden subtitle. Every default AI menu item is `size: "small"`, so the whole AI menu - prompt actions and the Retry / Cancel error state - rendered stretched. Declares the floor only on the items it is for, rather than setting it for everything and having the small rule try to undo it. `height: fit-content` goes with it: it only ever existed to beat the old fixed `height`. A new size variant is now content-sized by default instead of silently inheriting the clamp. Mantine only: ariakit and shadcn never set a height on suggestion items.
YousefED
added a commit
that referenced
this pull request
Aug 31, 2026
The AI menu had no coverage that could catch this: the one AI screenshot (`ai_menu_scroll_position`) is a `document.body` shot on an 800x400 viewport where the menu is clipped just below the first item, which is why #2909 only needed to update the *slash* menu baselines. Screenshots the AI menu in its prompt and error states. Without the fix the menu is 88px taller, so both fail on all three browsers before pixels are even compared: "Expected image dimensions to be 623x200px, but received 623x288px".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adjusts the Mantine slash menu styling to prevent overflow for items with long titles or descriptions.
Closes #2744
Rationale
Item descriptions (especially custom ones) can get pretty long, and causing visual issues.
Changes
Impact
N/A
Testing
Updated e2e screenshots
Screenshots/Video
N/A
Checklist
Additional Notes
N/A
Summary by CodeRabbit