fix(connector): inherit shared proxy and bound startup - #958
Draft
enderzcx wants to merge 1 commit into
Draft
Conversation
|
@enderzcx is attempting to deploy a commit to the luokerenx4's Team Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ALL_PROXY) and resolve the host system proxy through Electron on every desktop platformRoot cause
The Connector child already inherited proxy environment variables, but grammY/node-fetch and Discord's REST stack supplied their own transports and bypassed Node's environment/global proxy behavior. Telegram could then wait on grammY's long API timeout and retries before the service ever bound its health port.
Verification
npx tsc --noEmitpnpm test— 469 files passed, 1 skipped; 3892 tests passed, 9 skippedpnpm buildpnpm test:connector-replaypnpm test:connector-servicepnpm electron:smoke:workspace; all packaged Workspace receipt checks passed and the temporary app was cleanedawaiting_linkafter identity validation and command publication; no test notification was sentScope and safety