Skip to content

fix log dupe at cmd completion #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amankrx merged 5 commits into from
Aug 20, 2026
Merged

fix log dupe at cmd completion #2694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7eeee73
fix log dupe at cmd completion
mridulmanohar Aug 16, 2026
3840f35
log for non linux target os
mridulmanohar Aug 16, 2026
86e5ab1
correct logs
mridulmanohar Aug 18, 2026
af11b12
assert logs string
mridulmanohar Aug 19, 2026
18ef5ec
Merge branch 'main' into mridul/fix-args-log-dup
amankrx Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nativelink-worker/src/running_actions_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1901,7 +1901,8 @@ impl RunningActionImpl {
#[cfg(not(target_os = "linux"))]
let resource_usage = None;

info!(?args, "Command complete");
// log something useful instead of repeating same ?arg
info!(?exit_code, "Command complete");

let maybe_error_override = if let Some(side_channel_file) = maybe_side_channel_file {
process_side_channel_file(side_channel_file.clone(), &args, requested_timeout).await
Expand Down
2 changes: 1 addition & 1 deletion nativelink-worker/tests/running_actions_manager_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3762,7 +3762,7 @@ exit 1
let command = "[\"cmd\", \"/C\", \"ping -n 99999 127.0.0.1\"]";

assert!(logs_contain(&format!("Executing command args={command}")));
assert!(logs_contain(&format!("Command complete args={command}")));
assert!(logs_contain("Command complete exit_code="));

assert!(!logs_contain(
"Child process was not cleaned up before dropping the call to execute(), killing in background spawn"
Expand Down
Loading