Skip to content

d3aa: Fix D3AA build without party strobe enabled - #68

Open
stcarlso wants to merge 2 commits into
ToyKeeper:trunkfrom
stcarlso:d3aa-fix
Open

stcarlso wants to merge 2 commits into
ToyKeeper:trunkfrom
stcarlso:d3aa-fix

Conversation

@stcarlso

Copy link
Copy Markdown

Fix the D3AA build without party strobe enabled, or some other function that defines USE_DELAY_ZERO.

Building Anduril for D3AA with party strobe disabled removes the only dependency that defines the delay_zero() function, which is used by the weak battery detection feature. This leads to an implicit function declaration and eventually a build break with an undefined symbol. Adding a definition to anduril.h resolves the issue and allows building normally.

Tested to build and run on Emisar D3AA.

@SammysHP

Copy link
Copy Markdown
Contributor

USE_WEAK_BATTERY_PROTECTION should add this as a dependency.

SiteRelEnby added a commit to SiteRelEnby/anduril that referenced this pull request Apr 29, 2024
SiteRelEnby added a commit to SiteRelEnby/anduril that referenced this pull request Apr 29, 2024
@SiteRelEnby

Copy link
Copy Markdown
Contributor

PR opened against your branch. When that is merged then ✅

SiteRelEnby added a commit to SiteRelEnby/anduril that referenced this pull request Apr 29, 2024
SiteRelEnby added a commit to SiteRelEnby/anduril that referenced this pull request Apr 29, 2024
SiteRelEnby added a commit to SiteRelEnby/anduril that referenced this pull request Apr 29, 2024
stcarlso added a commit to stcarlso/anduril that referenced this pull request Apr 29, 2024
Anduril PR ToyKeeper#68: automatically include delay_zero() when using weak battery protection
stcarlso pushed a commit to stcarlso/anduril that referenced this pull request Apr 29, 2024
isilmerie pushed a commit to isilmerie/anduril that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants