Repository navigation
Conversation
The 16-bit voltage measurement readout was truncated due to an incorrect cast to uint8_t. Avoid arithmetic overflow.
Owner
|
Of course... the one I didn't test is broken. :D Will have to see if I can find the adapter I used years ago to flash a fw3x. I didn't test because the flashing pins are swapped and I apparently misplaced the one adapter I had with remappable pins. But it's got to be around here somewhere... |
Owner
|
Fixed in 026624c. Thanks for finding this, testing it, and making a one-liner patch to fix it. I fixed it in a different way though, removing the broken code entirely so it can use the new voltage system. I only have one FW3X to test it on, so I'm not sure how much hardware varies from one unit to another, but the calibration I used gives me results which are within 0.005V of the actual value. Hopefully others will be pretty close too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 16-bit voltage measurement readout was truncated due to an incorrect cast to
uint8_t. Avoid arithmetic overflow.Tested on FW3X-lume1 hardware to correctly blink out the voltage; before, it would blink out nonsense numbers like 0.02 V.