Build the vector backend decision harness - #1207
Conversation
0f7eaa0 to
50bbbed
Compare
Review contextPR #1207 is the measured decision lane for #1202. It compares sqlite-vec and USearch without adopting either backend; Review scopeIndependently reviewed exact head Checks and findings
Disposition
This review does not select a backend, close #1202, unblock #1196, or prove Windows x64 production behavior. After the code fixes, the next gate is exact-head CI and independent review followed by the full retained Windows evidence set. |
Independent review checkpointExact head
Separately, #1202 remains a non-decision: the reviewed 30-query catalog, production 1k/10k/25k/100k Windows artifacts, isolated timing/RSS/cancellation/deep-validation/package/license evidence, clean-host reproduction, fallback proof, and recommendation are still missing. No backend adoption is authorized. |
Corrected exact-head checkpointExact head The publication-boundary re-review found no source defect: native parent identity is captured before open, verified against the retained handle, reused for later path checks, and covered by privilege-free pre-open replacement tests on Windows and Unix. Focused workspace and fixture tests, Windows-target checking, #1202 is still a non-decision. The reviewed 30-query catalog, production 1k/10k/25k/100k Windows artifacts, isolated timing/RSS/cancellation/deep-validation/package/license evidence, clean-host reproduction, fallback proof, and recommendation remain missing. This head fixes the harness; it does not authorize backend adoption or close the issue. |
|
Closing this draft without merge. Exact head #1202 remains open and parked. A future attempt starts from the then-current |
Context
Issue #1202 needs a predeclared, reproducible comparison between sqlite-vec and USearch before CodeStory can replace its current embedded vector scan. This draft adds the comparison and evidence machinery without selecting or adopting either backend.
Current remote head:
e718ac01832199a91e9a9b910b37a78dee28a1d5, based ondev/codestory-nextat6de1c2717b68e6f97996ae21f38256a2645d7a5a.On 2026-07-16 the owner changed the blocking decision profile from Windows x64 to macOS arm64 on the local Apple Silicon host. The live issue and Project reflect that decision. A replacement branch head aligning the criteria, harness, workflow, and documentation is in progress; the current remote head still contains the prior Windows-specific contract.
Closes #1202
Refs #1179
What changed on the current remote head
The replacement head will change only the blocking profile and evidence infrastructure. It will not adopt a backend.
How to review
benchmarks/vector-backend-spike/criteria.json; it is the decision contract.crates/codestory-retrieval/src/embedded_vector.rs.crates/codestory-workspace/src/owned_publication.rs.crates/codestory-bench/tests/vector_backend_spike.rsand its driver.Verification
Focused checks on exact remote head
e718ac01832199a91e9a9b910b37a78dee28a1d5:cargo test --locked -p codestory-workspace owned_publication— 4 passed.cargo test --locked -p codestory-retrieval vector_fixture_sampling_is_ordered_and_fails_closed_on_wal_drift— 1 passed.cargo test --locked -p codestory-bench --no-default-features --features fixture-generator --test vector_backend_spike— 9 passed, 2 intentionally ignored.x86_64-pc-windows-msvccodestory-workspaceClippy with warnings denied — passed.cargo check --locked -p codestory-workspace --target x86_64-pc-windows-msvc— passed.cargo fmt --all -- --check— passed.git diff --check— passed.node .github/scripts/check-doc-links.mjs— 73 files, 243 relative links.Those checks prove the current source contract only. Replacement-head checks and independent exact-head review are required after the Mac evidence lane lands.
Risk and remaining evidence
This PR cannot support a backend recommendation yet and must remain draft.
criteria.jsonremainsblocked_pending_required_evidence.Missing decision evidence includes:
Existing local caches do not contain a complete decision corpus. Synthetic or undersized data remains non-decision evidence. Linux and Windows packaging proof is non-blocking for this non-adopting spike; if a candidate wins, those platforms move to the later adoption PR. Keep the existing embedded scan unless one candidate clears every predeclared macOS arm64 gate.