Repository navigation
Conversation
devam007
requested review from
Panquesito7 and
realstealthninja
as code owners
October 23, 2026 18:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Return -1 for n <= 0 before jump search reads the array. Previously, a zero-sized
step could read arr[-1] and even return a match for a logically empty range.
Add assertions for empty input, null with zero length, singletons, duplicates,
end-position matches and absent targets. Retain the existing example.
Validation
GCC 15.2 / C++17: 41,311 focused reference comparisons pass against
std::binary_search with seeded sorted inputs and boundary targets. A safe backing-
array reproduction returns an incorrect match on the base and -1 with the fix.
Warning-enabled compilation with libstdc++ assertions, the CMake/Ninja target,
the source assertions and git diff --check pass. Remote CI, clang-format and
clang-tidy were not run locally.
Related prior work: #3169 included empty-input handling in a broader vector/API rewrite and was closed unmerged after inactivity. This patch keeps the existing array API and limits the change to the boundary guard and regression assertions.