You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(examples/preact/{ssr,ssr-streaming}): only send the error stack in development - #12413
examples/preact/{ssr,ssr-streaming}/server.js: when rendering a page throws, respond with 'Internal Server Error' in production instead of e.stack, so internal paths and error details aren't sent to the client. In development the stack is still sent, and the server keeps logging it in both modes. This matches how Express's default error handler treats the stack, and the onError handler in ssr-streaming, which already responds with 'Internal Server Error'.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
examples/preact/{ssr,ssr-streaming}/server.js: when rendering a page throws, respond with'Internal Server Error'in production instead ofe.stack, so internal paths and error details aren't sent to the client. In development the stack is still sent, and the server keeps logging it in both modes. This matches how Express's default error handler treats the stack, and theonErrorhandler inssr-streaming, which already responds with'Internal Server Error'.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact