fix(plugins): sync TableProCore PluginKit SSLHandshakeError with the framework#1531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Shared contract drift" CI gate (
scripts/audit-refactor-health.sh --check) fails on every PR cut from currentmain:SSLHandshakeErrorexists in two PluginKit trees that are kept byte-identical until consolidation:Plugins/TableProPluginKit/SSLHandshakeError.swift(framework, canonical)Packages/TableProCore/Sources/TableProPluginKit/SSLHandshakeError.swift(package copy)#1520 added three client-key cases to the framework copy (
clientKeyPassphraseRequired,clientKeyPassphraseIncorrect,clientKeyInvalid) but didn't mirror them into the package copy, so the two drifted. The baseline doesn't list the file, and its header says not to baseline fresh divergence, so the right fix is to re-sync.Fix
Add the three missing cases to the package copy so it matches the framework contract byte for byte. No behavior change on the desktop app (it builds against the framework copy, which already had them); this restores the package/TableProCore copy that the gate compares.
Verified locally:
This unblocks the drift gate for all open PRs, not just one.