fix(plugins): update incompatible plugins quietly after an app ABI bump (#1322)#1382
Merged
Conversation
…le and give exhausted failures a clear reason (#1322)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After a PluginKit ABI bump (registry plugins moved 13 to 14 across the 0.43.x updates), users who had plugins installed on an older app version saw a "could not be loaded" notification on launch and an alert when updating, even though the registry already carried compatible builds. Reported in #1322. Two earlier fixes (#1343, #1371) handled the happy path, but the notification still fired too early and one registry entry was unusable.
Root cause
pluginKitVersion: null, which can never match the app's exact-version lookup, so it stayed permanently rejected and kept triggering the notification.Fix
installLooseBundlestrips quarantine after verifying the signature, so a hand-installed plugin loads without the Gatekeeper dead end.update-registry.pydrops binaries without a concrete integerpluginKitVersion, so a null entry can no longer shadow a valid build.Follow-up (registry, separate repo)
The live
TableProApp/pluginsmanifest still has the DynamoDB null binary. Re-release the registry plugins (scripts/release-all-plugins.sh 14) so the hardened script drops it and DynamoDB resolves on app v14.Tests
Localizable.xcstrings is left out of this PR; the new strings extract on the next build.