feat: only output error message if LLM returns no actionable command#53
Open
corneliusroemer wants to merge 1 commit intoTNG:mainfrom
Open
feat: only output error message if LLM returns no actionable command#53corneliusroemer wants to merge 1 commit intoTNG:mainfrom
corneliusroemer wants to merge 1 commit intoTNG:mainfrom
Conversation
The script now checks immediately if the returned command matches the designated failure message before proceeding with further actions like explanation or option printing. This modification ensures that if the input prompt is unclear, the script directly outputs a clear error message and exits without executing additional unnecessary steps, aligning better with user expectations and reducing confusion. This change improves user experience by providing immediate feedback on input validity and makes the script's flow more logical and efficient. Resolves TNG#52 Signed-off-by: Cornelius Roemer <cornelius.roemer@gmail.com>
heiderich
reviewed
Jan 12, 2025
| get_command | ||
|
|
||
| if test "${command}" = "${fail_msg}"; then | ||
| exit 1 |
Contributor
There was a problem hiding this comment.
On my system this seems to result in no error message being shown at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script now checks immediately if the returned command matches the designated failure message before proceeding with further actions like explanation or option printing.
This modification ensures that if the input prompt is unclear, the script directly outputs a clear error message and exits without executing additional unnecessary steps, aligning better with user expectations and reducing confusion.
This change improves user experience by providing immediate feedback on input validity and makes the script's flow more logical and efficient.
Resolves #52
Signed-off-by: Cornelius Roemer cornelius.roemer@gmail.com