Repository navigation
fix: contributor crediting, and a tiered contributor section - #1180
Merged
Merged
Conversation
Contributor
Model quality report
Pre-existing:
✅ unchanged · ✨ improved vs Reaction directions: the alarm and the warning catch only directions that thermodynamics makes very unlikely. A reaction without an alarm or warning is not thereby shown to have the right reversibility. Full workflow run · this comment is edited as results come in |
edkerk
force-pushed
the
chore/contributors
branch
from
October 30, 2026 16:19
bb49ede to
65ae180
Compare
The Add contributor workflow used peter-evans/create-pull-request, which the repository's allowed-actions list does not include, so every run since the July overhaul ended in startup_failure and no credit was added. - code/contributors.py keeps .all-contributorsrc and the README table and checks them; no Node needed. - `/credit @user bug, research` (one line per person) adds to one rolling pull request, contributors/pending, rebuilt from develop each time. The answer is added under the command, with errors for unknown types or users. - After a merge into develop, uncredited issue and PR authors are proposed as ready-made /credit lines for a maintainer to confirm. - When the credit pull request is merged, each person is thanked where they were credited. - Contributor list: Hao Wang's renamed login, one entry for Pierre-Etienne Cholley, four missing reporters, GitHub profile links for entries without one. - README: contributor section in three tiers (core team, curators and developers, error reports and ideas) by number of contribution types, then by name. - CONTRIBUTING and the PR template explain the flow.
edkerk
force-pushed
the
chore/contributors
branch
from
October 31, 2026 17:09
65ae180 to
ec3f7b3
Compare
# Conflicts: # code/test/unit/conftest.py # data/testResults/model_qc_comment.md # data/testResults/model_qc_summary.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes contributor crediting, which has not worked since the July overhaul (#1049), and makes it easier to use and more visible.
The
Add contributorworkflow usedpeter-evans/create-pull-request, which is not in the repository's list of allowed actions. GitHub refused to start it: every run since then ended instartup_failure(200+ runs, one per issue comment), and no credit was added.Crediting
/credit @user bug, researchon any issue or pull request, one line per person. The older@all-contributors please add …is still understood.contributors/pending, againstdevelop. It is rebuilt fromdevelopon each command, so it never conflicts.develop, a comment lists ready-made/creditlines for the people involved who are not in the list yet: the authors of the closed issues and of the pull request. Nothing is credited until a maintainer replies with them.actions/checkoutis used, withghandpython3from the runner.Code
code/contributors.py(new) keeps.all-contributorsrcand the README section and replaces the all-contributors CLI, so Node is no longer needed.add,generateandcheckcan be run locally;checkfails on unknown types, a person listed twice, or a README that is out of date.code/test/unit/test_contributors.py(new): 15 tests.Contributor list (43 → 46)
Hao-Chalmers→haowang-bioinfo(account renamed)pecholleymerged intopecholleycNantiaL)chechung)zrf492174)szkabelREADME
Docs
CONTRIBUTING.md, "Crediting contributors": the new flow, for contributors and for maintainers.pull_request_template.md: the footer points to the new flow.The workflow acts on comments and merges as it is on
main, so it takes effect after the next release. It has not run on GitHub yet; the commands were tested locally against real issues and pull requests.