Skip to content

Announce item name when it's removed from a table #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryceStevenWilley merged 4 commits into from
Jul 23, 2026
Merged

Announce item name when it's removed from a table #66

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8ab680
Announce to screen readers when an item is removed
rajeswari1301 Jul 15, 2026
a0db891
Use item name and fix screen reader announcement reliability
rajeswari1301 Jul 16, 2026
ff0b14a
Move aria-live server/JS changes to a follow-up branch
rajeswari1301 Jul 22, 2026
d660188
Fix incorrect revert that accidentally undid unrelated app.js changes
rajeswari1301 Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docassemble_base/docassemble/base/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4580,7 +4580,8 @@ def process_action():
if the_action == '_da_list_remove':
if 'action_item' in this_thread.current_info and 'action_list' in this_thread.current_info:
try:
this_thread.current_info['action_list'].pop(this_thread.current_info['action_item'])
item_popped = this_thread.current_info['action_list'].pop(this_thread.current_info['action_item'])
log(str(item_popped) + ' ' + word('removed') + '.', 'info')
if len(this_thread.current_info['action_list'].elements) == 0 and hasattr(this_thread.current_info['action_list'], 'there_are_any'):
this_thread.current_info['action_list'].there_are_any = False
if hasattr(this_thread.current_info['action_list'], 'there_is_another') and this_thread.current_info['action_list'].there_is_another:
Expand All @@ -4604,7 +4605,8 @@ def process_action():
if the_action == '_da_dict_remove':
if 'action_item' in this_thread.current_info and 'action_dict' in this_thread.current_info:
try:
this_thread.current_info['action_dict'].pop(this_thread.current_info['action_item'])
item_popped = this_thread.current_info['action_dict'].pop(this_thread.current_info['action_item'])
log(str(item_popped) + ' ' + word('removed') + '.', 'info')
if len(this_thread.current_info['action_dict'].elements) == 0 and hasattr(this_thread.current_info['action_dict'], 'there_are_any'):
this_thread.current_info['action_dict'].there_are_any = False
if hasattr(this_thread.current_info['action_dict'], 'there_is_another') and this_thread.current_info['action_dict'].there_is_another:
Expand Down