Repository navigation
Support docassemble 1.10 button groups - #1118
Draft
nonprofittechy wants to merge 1 commit into
Draft
nonprofittechy wants to merge 1 commit into
nonprofittechy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docassemble 1.10 renders button groups as
.da-button-setcontainers. ALKiln currently discovers no yes/no button fields in those groups, so a generated scenario fails before answering its first branch question. Add the new container to field discovery and the Continue/signature fallback selectors.Validation: 277 unit tests pass, including three new regressions using div-based button groups. A real localhost docassemble 1.10.10 replay passes the true branch, two list entries, destination assertion, and final answer/negative-path assertions (4 steps). The fix is based on the current v5 branch.