Repository navigation
Add exception for AL - detect custom error screen #656
Description
Activity
- changed the title
[-]AL custom error is blocking kiln's ability to report errors to the developer[/-][+]Add exception for AL - detect custom error screen[/+]on Oct 2, 2024 Nothing is as powerful as an issue whose time has come.
- linked a pull request that will close this issueCatch `al_custom_error_screen` errors #1116
on Sep 10, 2026 - added a commit that references this issue
on Sep 10, 2026 Story Table now catches
al_custom_error_screenerror. Previously, Story Tables that ran into this screen would get stuck on the AL error page infinitely. Next steps: Linear Steps need additional development. Currently linear Steps succeed even when they run into AL's error page. See PR #1116.[On the whole, I agree with aligning linear Step behavior with Story Table behavior I think.]
still seems to not work when not going through the story table for some reason? Just putting And I tap to continue multiple times, the error is checked, but Kiln doesn't do anything with it and just continues going, says the test passed. https://github.com/SuffolkLITLab/ALKiln/blame/v5/lib/scope.js#L2325-L2340
- @BryceStevenWilleySince we work so closely with the Document Assembly Line project, detecting this as an official error seems reasonable. I'm not sure linear Steps handle errors at all currently. Generally, linear Steps in ALKiln tests are expected to explicitly test for page IDs if they want to detect an unexpected page ID. Failing on system error screens does seem like a good exception!
One theoretical counter-argument: failing when an interview reaches an error screen is potentially breaking behavior. ALKiln tests that are testing error screens, such as internal docassemble tests, may desire to detect that a page has reached an error screen and may desire to check the contents of that page. [That said, keeping linear Steps as they are would diverge behavior between Story Tables and linear Steps. That divergence may be justified considering our other expectations for linear Steps, but I feel most users would expect such behavior.]
This isn't fully handled yet. We'll close the issue once the linear Steps also fail on system the currently handled system errors.
Assembly Line is now trying to show the error to the developer in a friendly way. Because of that, ALKiln does not detect that an error has happened. I believe the AL screen id is "custom error action". We need to detect that and get the error from the right element (it's still there, just hidden in collapsed content).
If we expand the collapsed content, will that show the full error or does it make you scroll? If the latter, that's a shame. We'll have to think what to do about that because we can't take a screenshot of that whole thing, at least not without changing the DOM to do it. Maybe we just have to leave the developer to get to that screen themselves :/ [That's a shame when something is going wrong with the tests themselves and it's therefore impossible to recreate manually. Right now, that only seems to be happening with this code caching problem and we're working on that, but who knows what'll come up in the future.]