Skip to content

Fix ASSA Title field not being saved in properties dialog#11635

Merged
niksedk merged 1 commit into
mainfrom
fix/assa-title-not-saved
Jun 15, 2026
Merged

Fix ASSA Title field not being saved in properties dialog#11635
niksedk merged 1 commit into
mainfrom
fix/assa-title-not-saved

Conversation

@niksedk

@niksedk niksedk commented Jun 15, 2026

Copy link
Copy Markdown
Member

Problem

Reported in #11634: in the ASSA (Advanced SubStation Alpha) Properties dialog, the Title field is shown and editable, but the edited value is not saved.

Cause

AssaPropertiesViewModel.LoadFromHeader() reads Title: from the [Script Info] header into ScriptTitle, but UpdateHeader() (run on OK) wrote back every other Script Info property except Title, so the value was silently discarded.

The format layer (AdvancedSubStationAlpha.cs) round-trips Title: correctly — it writes subtitle.Header verbatim — so the value just never made it back into the header from the UI.

Fix

Add the missing call in UpdateHeader():

UpdateTag("Title", ScriptTitle, string.IsNullOrWhiteSpace(ScriptTitle));

This matches the SSA properties dialog (SsaPropertiesViewModel.cs), which already has this line and works correctly. No change is needed for SSA.

Notes

🤖 Generated with Claude Code

The ASSA properties dialog loaded the Title from the [Script Info]
header but never wrote it back on OK, so edits were silently dropped.
Add the missing UpdateTag("Title", ...) call, matching the SSA dialog.

Fixes #11634

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@niksedk niksedk merged commit f4c385d into main Jun 15, 2026
1 of 3 checks passed
@niksedk niksedk deleted the fix/assa-title-not-saved branch June 15, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant