Fix Pipe Surface Floater's movements

[tornac1234]

Linked Issues / Context

• Pipe surface floater used to be highly inconsistant with how they would be fully deployed and surface correctly.
• RemotelyControlled entities would be teleported once around 0, 0, 0 at first, which would cause some unexpected errors

Description of Change

• Reworked RemotelyControlled so it's smoother for both entities and swimming creatures (in particular, reaper leviathans used to teleport once every few meters)
• Fix RemotelyControlledPipeFloater to properly detect surfacing and act accordingly when it should be static
• Remove useless GC allocations in EntityPositionBroadcaster by reworking a good part of it

Validation

To observe the actual PipeSurfaceFloater fix:

• connect with Player A and Player B
• type subnautica command item pipesurfacefloater to get one
• throw it with one player, observe its movement with the other player
• when it's surfaced, make sure neither player can move it by pushing it. also try stepping on it to make sure that it's at the exact same place for both players

To observe Reaper Leviathan's movements improvements (as a side effect from the whole rework):

• connect with Player A and Player B
• type subnautica command spawn reaperleviathan
• observer that it no longer glitches every few meters

PR Checklist

• PR rebased on top of main at the time of opening
• Has tests for the changes (if applicable)
• Has a linked issue
• Has been tested in-game (if applicable)
• Has been tested on Windows/Linux/macOS (if applicable) (for cross-platform code)

---

AI was used to review myself before opening this PR

[tornac1234]

I'll send a commit with slight corrections (fixing the test too) once #2845 is merged

[github-actions]

Test Results

272 tests  +3   267 ✅ +3   10s ⏱️ ±0s
  1 suites ±0     5 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit e7b82de. ± Comparison against base commit 24730bf.

This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both.

Nitrox.Test.Patcher.Patches.PatchesTranspilerTest ‑ AllPatchesTranspilerSanity (NitroxPatcher.Patches.Dynamic.CrashHome_Spawn_Patch,2)
Nitrox.Test.Patcher.Patches.PatchesTranspilerTest ‑ AllPatchesTranspilerSanity (NitroxPatcher.Patches.Dynamic.PipeSurfaceFloater_FixedUpdate_Patch,2)

Nitrox.Model.Extensions.DictionaryExtensionsTest ‑ RemoveWhere_ShouldHandleEmptyDictionary
Nitrox.Model.Extensions.DictionaryExtensionsTest ‑ RemoveWhere_ShouldHandleRemovingAllItems
Nitrox.Model.Extensions.DictionaryExtensionsTest ‑ RemoveWhere_WithExtraParameter_ShouldRemoveMatchingItems
Nitrox.Model.Extensions.DictionaryExtensionsTest ‑ RemoveWhere_WithoutParameter_ShouldRemoveMatchingItems
Nitrox.Test.Patcher.Patches.PatchesTranspilerTest ‑ AllPatchesTranspilerSanity (NitroxPatcher.Patches.Dynamic.CrashHome_Spawn_Patch,-5)

♻️ This comment has been updated with latest results.

[tornac1234]

Added a commit to answer the requested changes. Also deprecated MultiplayerVehicleControl for good since it was entirely replaced by MovementReplicator.

[Copilot]

🟡 Changes recommended

Ownership notifications, cell-transfer handling, and coordinate conversion currently introduce synchronization regressions.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Improves remote entity movement, pipe-floater synchronization, and position broadcasting efficiency.

Changes:

• Reworks remote movement smoothing and teleport correction.
• Makes surfaced pipe floaters static for remote players.
• Refactors entity broadcasting and simulation ownership synchronization.

File summaries

File	Description
NitroxPatcher/Patches/Dynamic/Vehicle_OnPilotModeEnd_Patch.cs	Removes obsolete vehicle control cleanup.
NitroxPatcher/Patches/Dynamic/SplineFollowing_GoTo_Patch.cs	Uses the broadcaster instance for spline updates.
NitroxPatcher/Patches/Dynamic/PropulsionCannon_GrabObject_Patch.cs	Updates entity-watching API usage.
NitroxPatcher/Patches/Dynamic/PipeSurfaceFloater_FixedUpdate_Patch.cs	Controls remote floater surfacing behavior.
NitroxPatcher/Patches/Dynamic/CreatureDeath_OnKillAsync_Patch.cs	Updates movement-control cleanup.
NitroxClient/Unity/Smoothing/SmoothVector.cs	Modernizes namespace formatting.
NitroxClient/Unity/Smoothing/SmoothRotation.cs	Modernizes namespace formatting.
NitroxClient/MonoBehaviours/Vehicles/WatchedEntry.cs	Corrects private field naming.
NitroxClient/MonoBehaviours/RemotelyControlledPipeFloater.cs	Locks surfaced floaters to synchronized transforms.
NitroxClient/MonoBehaviours/RemotelyControlled.cs	Reworks remote physics and spline movement.
NitroxClient/MonoBehaviours/MultiplayerVehicleControl.cs	Removes obsolete vehicle smoothing implementation.
NitroxClient/MonoBehaviours/EntityPositionBroadcaster.cs	Refactors tracking and reduces allocations.
NitroxClient/GameLogic/SimulationOwnership.cs	Centralizes ownership acquisition and broadcasting.
NitroxClient/GameLogic/RemotePlayer.cs	Adds distance-based teleport correction.
NitroxClient/GameLogic/MovementHelper.cs	Extracts teleport and correction helpers.
NitroxClient/GameLogic/Items.cs	Claims ownership immediately for dropped items.
NitroxClient/GameLogic/Entities.cs	Clears unresolved broadcaster entries during spawning.
NitroxClient/Communication/Packets/Processors/RemoveCreatureCorpseProcessor.cs	Updates broadcaster API usage.
NitroxClient/Communication/Packets/Processors/EntityTransformUpdatesProcessor.cs	Removes a stray statement.
Nitrox.Test/Patcher/Patches/PatchesTranspilerTest.cs	Removes the obsolete transpiler expectation.
Nitrox.Server.Subnautica/Models/Packets/Processors/EntitySpawnedByClientProcessor.cs	Changes ownership assignment for client spawns.
Nitrox.Server.Subnautica/Models/Packets/Processors/CellVisibilityChangedProcessor.cs	Bundles simulation data with spawned entities.
Nitrox.Server.Subnautica/Models/GameLogic/Entities/EntitySimulation.cs	Shares simulation policy and adds forced assignment.
Nitrox.Model/Extensions/DictionaryExtensions.cs	Adds pooled conditional dictionary removal.
Nitrox.Model.Subnautica/Packets/SpawnEntities.cs	Revises simulation-aware constructors.
Nitrox.Model.Subnautica/Helper/SimulationWhitelist.cs	Moves simulation policy into the shared model.

Review details

• Files reviewed: 26/26 changed files
• Comments generated: 6
• Review effort level: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dartasen]

I find the usage of RemoveWhere in this class really weird, we're adding side effects to a boolean predicate

[tornac1234]

If you can suggest a better name for RemoveWhere please, I've been thinking but it's really hard. Also I really think the performance gain from it is worth it. So either we rename it or we copy paste the code twice 😩

[tornac1234]

Now with 3861f6d, fixes #2473 (PrefabPlaceholderGroup assumed all databox spawners were PrefabPlaceholder while they might also be PrefabPlaceholderGroup ) and #2543 (NitroxEntitySlots didn't take into account all transform hirerarchy up to their designed root)

[Measurity]

LGTM

PipeSurfaceFloater audio plays while holding but appears to be vanilla bug.