feat(http-request): add stream option and download response metadata#151
Merged
feat(http-request): add stream option and download response metadata#151
Conversation
jdalton
force-pushed
the
feat/http-download-response-metadata
branch
3 times, most recently
from
5b65888 to
e0c924a
Compare
jdalton
changed the title
Merged
Add stream option to httpRequest — resolves with HttpResponse immediately after headers arrive, leaving rawResponse unconsumed for piping to files. Refactor httpDownloadAttempt to use httpRequestAttempt with stream: true, eliminating ~120 lines of duplicated HTTP plumbing (redirect handling, protocol selection, error enrichment). Add headers, ok, status, and statusText to HttpDownloadResult so callers can inspect response metadata after streaming downloads.
jdalton
force-pushed
the
feat/http-download-response-metadata
branch
from
e0c924a to
bb226c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
streamoption onhttpRequest— resolves withHttpResponseimmediately after headers arrive, leavingrawResponseunconsumed for piping to filesheaders,ok,status,statusTextfields onHttpDownloadResulthttpDownloadto usehttpRequestwithstream: trueinternally, eliminating ~120 lines of duplicated HTTP plumbingTest plan