Conversation
|
The two checks are because the current msrv is 1.70, whereas the newer dependencies require a more recent rustc. Should I downgrade these dependencies to keep compatibility with that June 2023 version, or would it be fine to bump our msrv? |
522105f to
708670c
Compare
|
Sorry for the delay on reviewing these MRs. Going through a bunch of them now. I have no requirements on MSRV as I use nightly or the latest Stable for most things. I think it should be fine to update them as anything shipped downstream would likely update their versions anyways when releasing it as part of a distribution package or something similar. |
Only rustyline required a code change. We might want to regenerate drm-ffi/drm-sys/src/bindings.rs with the newer bindgen at some point.
a671e22 to
4ebed68
Compare
This version stabilized the file_lock feature, required by rustyline.
f0f1128 to
8aaf295
Compare
|
Sorry, I think I broke that PR, and I don’t quite understand why. The check pass is complaining about |
No worries. It probably got broke by something else that got merged or some minimal version not being compatible. I'll take a look over the next few days to see if I can figure out the problem. |
|
Hey, is there any progress on this? |
Only
rustylinerequired a code change.We might want to regenerate
drm-ffi/drm-sys/src/bindings.rswith the newerbindgenat some point.