Skip to content

Bump all dependencies - #234

Open
linkmauve wants to merge 3 commits into
Smithay:developfrom
linkmauve:eijebong
Open

linkmauve wants to merge 3 commits into
Smithay:developfrom
linkmauve:eijebong

Conversation

@linkmauve

Copy link
Copy Markdown
Contributor

Only rustyline required a code change.

We might want to regenerate drm-ffi/drm-sys/src/bindings.rs with the newer bindgen at some point.

@linkmauve

Copy link
Copy Markdown
Contributor Author

The two checks are because the current msrv is 1.70, whereas the newer dependencies require a more recent rustc. Should I downgrade these dependencies to keep compatibility with that June 2023 version, or would it be fine to bump our msrv?

@linkmauve
linkmauve force-pushed the eijebong branch 3 times, most recently from 522105f to 708670c Compare March 2, 2026 13:25
@Slabity

Slabity commented Apr 20, 2026

Copy link
Copy Markdown
Collaborator

Sorry for the delay on reviewing these MRs. Going through a bunch of them now.

I have no requirements on MSRV as I use nightly or the latest Stable for most things. I think it should be fine to update them as anything shipped downstream would likely update their versions anyways when releasing it as part of a distribution package or something similar.

Only rustyline required a code change.

We might want to regenerate drm-ffi/drm-sys/src/bindings.rs with the
newer bindgen at some point.
@linkmauve
linkmauve force-pushed the eijebong branch 3 times, most recently from a671e22 to 4ebed68 Compare April 20, 2026 17:30
This version stabilized the file_lock feature, required by rustyline.
@linkmauve
linkmauve force-pushed the eijebong branch 4 times, most recently from f0f1128 to 8aaf295 Compare April 20, 2026 17:51
@linkmauve

Copy link
Copy Markdown
Contributor Author

Sorry, I think I broke that PR, and I don’t quite understand why. The check pass is complaining about linux/bits.h not existing, which should be fixed by my last WIP commit but isn’t. The check-minimal pass I understand better, the image crate depends on png which depends on flate2 which depends on miniz-sys which depends on gcc, but all of these are in super old versions which required an unstable feature from nightly, but I don’t quite get how to fix that, unless with time traveling.

@Slabity

Slabity commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

Sorry, I think I broke that PR, and I don’t quite understand why. The check pass is complaining about linux/bits.h not existing, which should be fixed by my last WIP commit but isn’t. The check-minimal pass I understand better, the image crate depends on png which depends on flate2 which depends on miniz-sys which depends on gcc, but all of these are in super old versions which required an unstable feature from nightly, but I don’t quite get how to fix that, unless with time traveling.

No worries. It probably got broke by something else that got merged or some minimal version not being compatible.

I'll take a look over the next few days to see if I can figure out the problem.

@HigherOrderLogic

Copy link
Copy Markdown

Hey, is there any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants