Add cloner for SkriptPotionEffect - #8820
Open
APickledWalrus wants to merge 2 commits into
Open
Conversation
APickledWalrus
added
the
bug
APickledWalrus
requested review from
UnderscoreTud and
cheeezburga
and removed request for
a team
August 7, 2026 20:52
skriptlang-automation
Bot
added
the
needs reviews
This comment has been minimized.
This comment has been minimized.
Absolutionism
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SkriptPotionEffect ClassInfo does not have a cloner defined, causing references to be shared across variables.
Solution
SkriptPotionEffect already supports cloning. I simply define a cloner to use the method.
Testing Completed
I added a small test to verify cloning. I verified that the test previously failed but now passes.
Supporting Information
Completes: none
Related: none
AI assistance: none