Add Scripts Loading/Unloading Events - #8816
Open
APickledWalrus wants to merge 2 commits into
Open
Conversation
🔍 Triage ChecklistType
Project
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It is not currently possible to detect when any script load/unload occurs (i.e. not the script itself loading/unloading).
Solution
Adds two new ScriptLoader events for "bulk" loads/unloads. This includes the first script load (on server start).
I've also added a new ScriptModule with events to listen to these two ScriptLoader events, with support for obtaining the loaded scripts given the script reflection experiment is enabled.
Testing Completed
basic test + more extensive in-game testing
Supporting Information
There are some parts that need further consideration:
loaded scriptsis not really possible as that already exists, and there needs to be a way to distinguish between the two.Completes:
Related: none
AI assistance: none