Treat SkriptPotionEffect as PotionEffect for ClassInfo comparison - #8814
Open
APickledWalrus wants to merge 1 commit into
Open
Treat SkriptPotionEffect as PotionEffect for ClassInfo comparison#8814APickledWalrus wants to merge 1 commit into
APickledWalrus wants to merge 1 commit into
Conversation
APickledWalrus
added
the
bug
skriptlang-automation
Bot
added
the
needs reviews
This comment has been minimized.
This comment has been minimized.
Absolutionism
left a comment
Absolutionism
left a comment
Contributor
There was a problem hiding this comment.
Would it not be better to allow ClassInfos to handle this instead of hard coding it only for SkriptPotionEffect?
Could benefit any other custom types that wrap a Bukkit object, with said Bukkit object being its own type as well. Especially for addons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
{_potion} is a potion effectdoes not currently work when the internal wrapperSkriptPotionEffectis the type.Solution
Adds a special case to the Object-ClassInfo comparator. This is certainly a bit questionable, but I don't think there are any other great solutions at the moment. It might be worth considering whether the wrapper is really needed, but that would be better fit as a feature change.
Testing Completed
Added an assertion for this case.
Supporting Information
Completes: none (reported on Discord)
Related: none
AI assistance: none