Sign Side Support - #8811
Open
APickledWalrus wants to merge 2 commits into
Open
Conversation
APickledWalrus
requested review from
Burbulinis and
UnderscoreTud
and removed request for
a team
August 3, 2026 21:59
APickledWalrus
added
enhancement
skriptlang-automation
Bot
added
the
needs reviews
This comment has been minimized.
This comment has been minimized.
This was
linked to
issues
Aug 3, 2026
Absolutionism
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Skript does not currently support sign sides which have now been in the game for many versions. There have been some PRs made in an attempt to resolve this, but none were ever merged.
Solution
I've moved remaining sign syntax into the new package and cleaned them up. Further, each one has new options for choosing a sign side (front or back). By default, the
frontside is preferred for compatibility.I've also added support for obtaining all lines of a sign. I did not include support for changing all lines. The API does not support this, though we could if we really wanted to. If we do, there are a few questions to answer:
Testing Completed
I've adjusted the existing tests and performed manual, in-game testing.
Supporting Information
Completes:
Related: none
AI assistance: none