Adopt hand-written liquid-html-parser for performance#1252
Merged
Conversation
References: artifacts/research/2026-07-14T1431-liquid-html-parser-world-copy-inventory.md and artifacts/plans/2026-07-14T1434-liquid-html-parser-world-resourcing-plan.md. Assisted-By: devx/e23cd8b6-9fad-4c85-8a59-927ec572d0d1
* Configure liquid-html-parser package Assisted-By: devx/bf1b845f-ea09-4e31-9686-5c3b1cb5ebc6 * Adapt liquid-html-parser to theme-tools source model (#1254) * Adapt liquid-html-parser to theme-tools source model * Add resilient liquid-html parsing (#1255) * Add resilient liquid-html parsing * rename to tolerant * Update theme-language-server-common for new parser (#1256) * Update theme-language-server-common for new parser * Fix NEW parser completion parity regressions Restores completion behavior lost in the NEW liquid parser so it matches OLD across empty/unclosed slots, pipe/filter routing, literal type-narrowing, liquid-inner-statement, named-filter-arg value slots, and abutting end-tag cases (A-G, R1, R2, R3). Fix branch-tag completion parity when abutting end tag Extends the abutting-endtag recovery to LiquidBranch (elsif/when); the R3 fix covered LiquidTag/ForMarkup only. * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser (#1257) * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser * Restore baseline fixture output for 10 parser and printer regressions Parser: - paginate tolerant argument parsing - comment/doc depth-balance - conditional comments - filter comma leniency - curly quotes - markdown script - nested same-name HTML tags - inline # indentation Printer: - liquid-doc trims - tablerow branched-body * Add changeset for hand-written liquid-html-parser (#1258) * Remove unnecessary change
* Configure liquid-html-parser package Assisted-By: devx/bf1b845f-ea09-4e31-9686-5c3b1cb5ebc6 * Adapt liquid-html-parser to theme-tools source model * Add resilient liquid-html parsing * rename to tolerant * Update theme-language-server-common for new parser * Fix NEW parser completion parity regressions Restores completion behavior lost in the NEW liquid parser so it matches OLD across empty/unclosed slots, pipe/filter routing, literal type-narrowing, liquid-inner-statement, named-filter-arg value slots, and abutting end-tag cases (A-G, R1, R2, R3). Fix branch-tag completion parity when abutting end tag Extends the abutting-endtag recovery to LiquidBranch (elsif/when); the R3 fix covered LiquidTag/ForMarkup only. * Update theme-check-common, prettier-plugin-liquid, and theme-graph for new parser * Restore baseline fixture output for 10 parser and printer regressions Parser: - paginate tolerant argument parsing - comment/doc depth-balance - conditional comments - filter comma leniency - curly quotes - markdown script - nested same-name HTML tags - inline # indentation Printer: - liquid-doc trims - tablerow branched-body * Add changeset for hand-written liquid-html-parser (#1258) * Remove unnecessary change * Copy world theme-check checks verbatim * Adapt ported theme-check checks to theme-tools--checks * Add changeset for ported theme-check checks * Regenerate factory configs for ported checks
stephanie-shopify
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the hand-written liquid-html-parser, replacing the Ohm grammar-based parser. Benchmarks on the theme corpus show it is roughly 75x faster than the Ohm parser.