-
Notifications
You must be signed in to change notification settings - Fork 84
Add Liquid docs bundle command #1240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
charlespwd
wants to merge
1
commit into
main
Choose a base branch
from
fix/theme-liquid-docs-bundle-cli
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@shopify/theme-check-docs-updater': minor | ||
| --- | ||
|
|
||
| Add a `theme-docs bundle` command/API for generating self-contained Liquid docs bundles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
packages/theme-check-docs-updater/src/themeLiquidDocsBundle.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
| import { buildThemeLiquidDocsBundle } from './themeLiquidDocsBundle'; | ||
|
|
||
| const manager = { | ||
| revision: async () => '40f966fc7793462726d9f8573c8d522f8ab44c54', | ||
| tags: async () => [{ name: 'if' }], | ||
| filters: async () => [{ name: 'upcase' }], | ||
| objects: async () => [{ name: 'product' }], | ||
| systemTranslations: async () => ({ 'shopify.checkout.general.cart': 'Cart' }), | ||
| schemas: async (mode: 'theme') => [ | ||
| { | ||
| uri: `https://example.com/schemas/${mode}.json`, | ||
| fileMatch: ['templates/*.json'], | ||
| schema: '{"type":"object"}', | ||
| }, | ||
| ], | ||
| }; | ||
|
|
||
| describe('Module: themeLiquidDocsBundle', () => { | ||
| it('builds a self-contained Liquid docs bundle', async () => { | ||
| await expect(buildThemeLiquidDocsBundle(manager)).resolves.toEqual({ | ||
| schemaVersion: 1, | ||
| revision: '40f966fc7793462726d9f8573c8d522f8ab44c54', | ||
| tags: [{ name: 'if' }], | ||
| filters: [{ name: 'upcase' }], | ||
| objects: [{ name: 'product' }], | ||
| systemTranslations: { 'shopify.checkout.general.cart': 'Cart' }, | ||
| schemas: [ | ||
| { | ||
| uri: 'https://example.com/schemas/theme.json', | ||
| fileMatch: ['templates/*.json'], | ||
| schema: '{"type":"object"}', | ||
| }, | ||
| ], | ||
| }); | ||
| }); | ||
|
|
||
| it('throws when the revision cannot be determined', async () => { | ||
| await expect( | ||
| buildThemeLiquidDocsBundle({ | ||
| ...manager, | ||
| revision: async () => '', | ||
| }), | ||
| ).rejects.toThrow('Unable to determine the theme-liquid-docs revision.'); | ||
| }); | ||
| }); |
56 changes: 56 additions & 0 deletions
56
packages/theme-check-docs-updater/src/themeLiquidDocsBundle.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| import { | ||
| FilterEntry, | ||
| ObjectEntry, | ||
| SchemaDefinition, | ||
| TagEntry, | ||
| Translations, | ||
| } from '@shopify/theme-check-common'; | ||
| import { ThemeLiquidDocsManager } from './themeLiquidDocsManager'; | ||
|
|
||
| export const ThemeLiquidDocsBundleSchemaVersion = 1; | ||
|
|
||
| export interface ThemeLiquidDocsBundle { | ||
| schemaVersion: typeof ThemeLiquidDocsBundleSchemaVersion; | ||
| revision: string; | ||
| tags: TagEntry[]; | ||
| filters: FilterEntry[]; | ||
| objects: ObjectEntry[]; | ||
| systemTranslations: Translations; | ||
| schemas: SchemaDefinition[]; | ||
| } | ||
|
|
||
| export interface ThemeLiquidDocsBundleManager { | ||
| revision(): Promise<string>; | ||
| tags(): Promise<TagEntry[]>; | ||
| filters(): Promise<FilterEntry[]>; | ||
| objects(): Promise<ObjectEntry[]>; | ||
| systemTranslations(): Promise<Translations>; | ||
| schemas(mode: 'theme'): Promise<SchemaDefinition[]>; | ||
| } | ||
|
|
||
| export async function buildThemeLiquidDocsBundle( | ||
| docsManager: ThemeLiquidDocsBundleManager = new ThemeLiquidDocsManager(), | ||
| ): Promise<ThemeLiquidDocsBundle> { | ||
| const [revision, tags, filters, objects, systemTranslations, schemas] = await Promise.all([ | ||
| docsManager.revision(), | ||
| docsManager.tags(), | ||
| docsManager.filters(), | ||
| docsManager.objects(), | ||
| docsManager.systemTranslations(), | ||
| docsManager.schemas('theme'), | ||
| ]); | ||
|
|
||
| if (!revision) { | ||
| throw new Error('Unable to determine the theme-liquid-docs revision.'); | ||
| } | ||
|
|
||
| return { | ||
| schemaVersion: ThemeLiquidDocsBundleSchemaVersion, | ||
| revision, | ||
| tags, | ||
| filters, | ||
| objects, | ||
| systemTranslations, | ||
| schemas, | ||
| }; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the first time I've seen the
\t\t\tand asked Claude about it. Apparently it's a way to align the descriptions into columns. C mentioned that there are some libraries that exist that that handle alignment automatically. Just curious what the tradeoffs are between this syntax and a library-- maybe a whole library is just overkill and the current syntax is more lightweight for the purposes you need?