Remove already_extends? helper method - #1014
Open
dejmedus wants to merge 1 commit into
Open
Conversation
`already_extends?` looks through child nodes to find pre-existing `extend`s. As they are deeper in the tree they are not being detected However, this logic isn't necessary as we will want to insert an `extend` statement prior to anything requiring it regardless. This commit removes the helper method and its checks
Morriar
reviewed
Aug 12, 2026
| unless already_extends?(node, /^(::)?T::Helpers$/) | ||
| extend_with("T::Helpers", into: node, at: insert_pos) | ||
| end | ||
| extend_with("T::Helpers", into: node, at: insert_pos) |
Contributor
There was a problem hiding this comment.
Shouldn't this be fully qualified?
Suggested change
| extend_with("T::Helpers", into: node, at: insert_pos) | |
| extend_with("::T::Helpers", into: node, at: insert_pos) |
| unless already_extends?(node, /^(::)?T::Generic$/) | ||
| extend_with("T::Generic", into: node, at: insert_pos) | ||
| end | ||
| extend_with("T::Generic", into: node, at: insert_pos) |
Contributor
There was a problem hiding this comment.
Suggested change
| extend_with("T::Generic", into: node, at: insert_pos) | |
| extend_with("::T::Generic", into: node, at: insert_pos) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
already_extends?misses pre-existingextendcalls #1013This PR removes the
already_extends?method and its checks. Of the options to handle thealready_extends?bug detailed in the issue, I believe removal is the most straightforward (maintains current behaviour) and least fragile