fix(hydrogen): call cart selector hook unconditionally in useOptionalCart#3845
Open
malewis5 wants to merge 3 commits into
Open
fix(hydrogen): call cart selector hook unconditionally in useOptionalCart#3845malewis5 wants to merge 3 commits into
malewis5 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
useOptionalCartcalled theuseCartSelectorhook after an earlyreturn undefinedwhen rendered outside a<CartProvider>. That makes ahook run conditionally, violating the Rules of Hooks: the number/order of
hooks changes between renders depending on whether a provider is present,
which can corrupt React's hook state and crash in dev.
WHAT is this pull request doing?
useOptionalCartnow always callsuseCartSelector, passing apossibly-
nullstore instead of returning early.useCartSelectoracceptsCartStore | null:getSnapshotreturnsundefinedwhen there's no store, and it subscribes via a no-opsubscribesouseRef/useSyncExternalStorealways run in the sameorder.
useCartcontinues to cast the result withas S, preserving thenon-optional return type;
useOptionalCartreturnsS | undefined.No behavioral change for consumers inside a provider.
HOW to test your changes?
From
packages/hydrogen: