fix(Manager): keep devices in gamepad order during target device changes - #642
Open
strycore wants to merge 1 commit into
Open
fix(Manager): keep devices in gamepad order during target device changes#642strycore wants to merge 1 commit into
strycore wants to merge 1 commit into
Conversation
When a composite device switches profiles, its target devices are stopped and re-attached. The RemoveFromGamepadOrder request is sent from a spawned task after the suspended state check, so it can arrive after a new gamepad target has already been attached. When that happens the device is dropped from the gamepad order even though it still has a gamepad target, and it is never re-added until the next gamepad attach. On systems where the session manager reloads profiles several times at boot this reliably left GamepadOrder empty with a controller connected and working. Only remove a device from the gamepad order if it no longer has any gamepad target attached.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a composite device switches profiles, its target devices are stopped and re-attached. The RemoveFromGamepadOrder request is sent from a spawned task after the suspended state check, so it can arrive after a new gamepad target has already been attached. When that happens the device is dropped from the gamepad order even though it still has a gamepad target, and it is never re-added until the next gamepad attach. On systems where the session manager reloads profiles several times at boot this reliably left GamepadOrder empty with a controller connected and working.
Only remove a device from the gamepad order if it no longer has any gamepad target attached.