Conversation
The --prom-port help was copied from --port and read "Port Consensus runs on", so `summit run --help` described the Prometheus metrics port (default 9090, paired with --prom-ip) as the consensus port. Describe the flag it actually configures.
devorun
force-pushed
the
fix/prom-port-help
branch
from
September 9, 2026 08:25
e09b167 to
64beb43
Compare
Author
|
Gentle follow-up on this one. I've rebased it onto current It's a one-line help-text fix: @matthias-wright would you mind taking a quick look when you have a moment? Happy to adjust the wording if you'd prefer something else. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--prom-port(default9090, paired with--prom-ip"Prometheus address") sets the port for the Prometheus metrics endpoint, but its help string was copied from--portand reads "Port Consensus runs on".As a result
summit run --helplabels both--portand--prom-portidentically, describing the metrics port as the consensus port. This corrects the--prom-portdescription to the flag it actually configures.--portis left unchanged.Doc-comment only; no behavior change.