Skip to content

Perf/disable extended thinking#161

Open
yonadavGit wants to merge 2 commits into
mainfrom
perf/disable-extended-thinking
Open

Perf/disable extended thinking#161
yonadavGit wants to merge 2 commits into
mainfrom
perf/disable-extended-thinking

Conversation

@yonadavGit

Copy link
Copy Markdown
Contributor

No description provided.

yonadavGit and others added 2 commits July 6, 2026 16:52
Extended thinking was active on every LLM call in the agent loop,
contributing ~46% of median latency (55s → 30s in probe). Disabling
it removes hidden reasoning passes without requiring them for this
retrieval-focused use case.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@yonadavGit yonadavGit requested a review from nsantacruz July 7, 2026 13:00
@gitvelocity-reviewer

Copy link
Copy Markdown

📊 Code Quality Score: 31/100

52 × 0.6 = 31.2 → 31

Category Score Factors
🔭 Scope 12/20 8+ files across frontend/backend/config; new SSE event type as public API; config cleanup cross-cutting
🏗️ Architecture 10/20 Clean callback protocol extension through agent stack; thinking disabled is behavioral change; SSE event routing added
⚙️ Implementation 11/20 Streaming delta extraction with dual-path logic; closure-based timing with nonlocal; Svelte 5 streaming state; SSE event type routing
⚠️ Risk 8/20 Model version unpinned (was date-pinned); thinking explicitly disabled; XSS surface with streaming HTML; new SSE event additive/backward-compatible
✅ Quality 9/15 Good unit tests for sdk_runner and metrics_mapper; missing orchestrator integration tests; no frontend tests; config cleanup well-executed
🔒 Perf / Security 2/5 scrollToBottom on every delta may cause perf issues; XSS risk with streaming HTML not addressed; no sanitization verification

Was this score accurate? 👍 Yes · 👎 No

Scored by GitVelocity · How are scores calculated?

@coolify-sefaria-github

coolify-sefaria-github Bot commented Jul 7, 2026

Copy link
Copy Markdown

The preview deployment for sefaria/ai-chatbot:server is ready. 🟢

Open app | Open Build Logs | Open Application Logs

Last updated at: 2026-07-07 14:09:01 CET

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant