Skip to content

fix: resolve Cargo configuration and build errors across RustChain crates (fixes #8095) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT] - #8191

Open
waterWang wants to merge 3 commits into
Scottcjn:mainfrom
waterWang:fix/cargo-build-errors
Open

fix: resolve Cargo configuration and build errors across RustChain crates (fixes #8095) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT]#8191
waterWang wants to merge 3 commits into
Scottcjn:mainfrom
waterWang:fix/cargo-build-errors

Conversation

@waterWang

Copy link
Copy Markdown
Contributor

Fix #8095: Cargo configuration and build errors

Changes

  1. miners/rust/Cargo.toml — feature rustls-tlsrustls (reqwest 0.13 uses rustls not rustls-tls)
  2. rustchain-miner/Cargo.toml — Same reqwest feature fix
  3. rust-tools/examples/rustchain-sdk/Cargo.toml — Moved bip39 and ed25519-dalek from [features] to [dependencies] as optional deps
  4. rust-tools/examples/rustchain-sdk/src/lib.rs — Created missing crate entry point
  5. rust-tools/sdk/ — Created missing sdk crate referenced by cli-wallet example
  6. rust-tools/examples/cli-wallet/src/main.rs — Created missing entry point
  7. rips/benches/entropy_bench.rs — Created missing benchmark file
  8. cross-chain-airdrop/Cargo.lock — Removed duplicate thiserror entry (same version 2.0.18 appeared twice)

Testing

  • ✅ Python syntax check on all changed files
  • ✅ All modifications are standard Cargo.toml / Cargo.lock / Rust source changes

…rrent mempool corruption (fixes Scottcjn#8176) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT]
…ates (fixes Scottcjn#8095) [fj4WqyCCw3C5ShR1RfB7MoBPTpkRrBFYP1uT35g3MvT]
@Scottcjn

Copy link
Copy Markdown
Owner

Holding this alongside #8190. This branch is stacked on it, so it carries the /p2p/gossip auth change as well as its own, and that change would break inter-node gossip as written. Details are in the review on #8190.

Nothing here is rejected. Once #8190 is revised, or once this is rebranched off current main so it carries only its own diff, I will review it on its own merits. main has moved a long way today, so a fresh branch is probably less work than untangling the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Cargo configuration and build errors across RustChain crates

2 participants