bazel: set BAZEL_SH only when msys2 bash exists - #8323
Open
l46983284-cpu wants to merge 1 commit into
Open
Conversation
env_set always wrote $(appdir msys2)/.../bash.exe even when msys2 was not installed, leaving a broken BAZEL_SH (ScoopInstaller#7402). Set the var only after Test-Path, document manual override, remove on uninstall. Closes ScoopInstaller#7402 Signed-off-by: Alex Chen <l46983284@gmail.com>
Contributor
Author
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. bazel
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughChangesBazel shell configuration
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
<manifest-name[@version]|chore>: <general summary of the pull request>Summary
bazelusedenv_setto always writeBAZEL_SHto$(appdir msys2)/current/usr/bin/bash.exe. Ifmsys2was only suggested (not installed), users got a non-existent path (#7402).This PR:
env_setBAZEL_SHininstalleronly when that bash path existsBAZEL_SHon uninstallCloses #7402
Test plan
bazel.jsonparses as JSON