dsc: Add version 3.2.3 - #6626
Conversation
|
Your changes do not pass checks. dsc
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. dsc
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. dsc
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughAdds a Scoop manifest for DSC version 3.2.3. The manifest defines metadata, x64 and arm64 download URLs with SHA256 hashes, maps ChangesDSC manifest
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
bucket/dsc.json (2)
18-31: Autoupdate hash extraction is valid, but consider a tiny tweak.Your pattern works with GitHub’s release body. For consistency with Scoop docs, you can use the alias key "find" instead of "regex" (behavior is identical). Optional only. (github.com)
- "hash": { - "url": "https://github.com/PowerShell/DSC/releases/tag/v$version", - "regex": "(?s)$basename.*?$sha256" - } + "hash": { + "url": "https://github.com/PowerShell/DSC/releases/tag/v$version", + "find": "(?s)$basename.*?$sha256" + }
3-3: Trim description (style nit).Suggestion to make it crisper:
- "Cross‑platform CLI to manage software components declaratively and idempotently."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bucket/dsc.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: WindowsPowerShell
🔇 Additional comments (4)
bucket/dsc.json (4)
2-2: Version mismatch with PR title/summary.Manifest is 3.1.1 but PR title/summary say 3.1.0. Please align the PR title/description or pin the manifest to 3.1.0 (3.1.1 is the latest stable as of September 8, 2025). (newreleases.io)
8-14: URLs and hashes look correct for v3.1.1 (x86_64/arm64).Both download URLs resolve to the release assets, and the SHA256 values match the upstream release notes. (newreleases.io)
17-17: checkver is appropriate."checkver": "github" will track stable releases. No changes needed. (github.com)
16-16: Binary mapping correct as-is Verified thatdsc.exeresides at the archive root, so"bin": "dsc.exe"requires no change.
|
/verify |
|
All changes look good. Wait for review from human collaborators. dsc
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. dsc
|
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Closes #6625
<manifest-name[@version]|chore>: <general summary of the pull request>