Skip to content

dsc: Add version 3.2.3 - #6626

Merged
z-Fng merged 6 commits into
ScoopInstaller:masterfrom
o-l-a-v:dsc-add
Aug 31, 2026
Merged

z-Fng merged 6 commits into
ScoopInstaller:masterfrom
o-l-a-v:dsc-add

Conversation

@o-l-a-v

@o-l-a-v o-l-a-v commented Mar 13, 2025

Copy link
Copy Markdown
Contributor

Closes #6625

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

@github-actions

Copy link
Copy Markdown
Contributor

Your changes do not pass checks.

dsc

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@o-l-a-v

o-l-a-v commented Mar 13, 2025

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

dsc

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@o-l-a-v o-l-a-v changed the title dsc: Add version 3.0.0 dsc: Add version 3.1.0 Jun 27, 2025
@o-l-a-v

o-l-a-v commented Jun 27, 2025

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

dsc

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@coderabbitai

coderabbitai Bot commented Sep 8, 2025

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1160e62b-bd5e-4afd-9f5c-f669cc4e27fb

📥 Commits

Reviewing files that changed from the base of the PR and between c806005 and 2fe6e77.

📒 Files selected for processing (1)
  • bucket/dsc.json

Summary by CodeRabbit

  • New Features
    • Added DSC 3.2.3 to the Scoop bucket for installation via Scoop.
    • Supports 64-bit and ARM64 architectures with matching downloads.
    • Includes SHA256 checksum verification for download integrity.
    • Configured automatic updates based on new GitHub releases.
    • Enables running dsc directly after installation.

Walkthrough

Adds a Scoop manifest for DSC version 3.2.3. The manifest defines metadata, x64 and arm64 download URLs with SHA256 hashes, maps dsc.exe, uses GitHub version checks, and configures architecture-specific autoupdate URLs.

Changes

DSC manifest

Layer / File(s) Summary
Release metadata and autoupdate configuration
bucket/dsc.json
Adds DSC 3.2.3 metadata, x64 and arm64 download details, dsc.exe mapping, GitHub checkver, and architecture-specific autoupdate URLs.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@o-l-a-v o-l-a-v changed the title dsc: Add version 3.1.0 dsc: Add version 3.1.1 Sep 8, 2025

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
bucket/dsc.json (2)

18-31: Autoupdate hash extraction is valid, but consider a tiny tweak.

Your pattern works with GitHub’s release body. For consistency with Scoop docs, you can use the alias key "find" instead of "regex" (behavior is identical). Optional only. (github.com)

-        "hash": {
-            "url": "https://github.com/PowerShell/DSC/releases/tag/v$version",
-            "regex": "(?s)$basename.*?$sha256"
-        }
+        "hash": {
+            "url": "https://github.com/PowerShell/DSC/releases/tag/v$version",
+            "find": "(?s)$basename.*?$sha256"
+        }

3-3: Trim description (style nit).

Suggestion to make it crisper:

  • "Cross‑platform CLI to manage software components declaratively and idempotently."
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b5a95db and 67ff1dc.

📒 Files selected for processing (1)
  • bucket/dsc.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell
🔇 Additional comments (4)
bucket/dsc.json (4)

2-2: Version mismatch with PR title/summary.

Manifest is 3.1.1 but PR title/summary say 3.1.0. Please align the PR title/description or pin the manifest to 3.1.0 (3.1.1 is the latest stable as of September 8, 2025). (newreleases.io)


8-14: URLs and hashes look correct for v3.1.1 (x86_64/arm64).

Both download URLs resolve to the release assets, and the SHA256 values match the upstream release notes. (newreleases.io)


17-17: checkver is appropriate.

"checkver": "github" will track stable releases. No changes needed. (github.com)


16-16: Binary mapping correct as-is Verified that dsc.exe resides at the archive root, so "bin": "dsc.exe" requires no change.

@o-l-a-v

o-l-a-v commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

github-actions Bot commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

dsc

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@z-Fng z-Fng changed the title dsc: Add version 3.1.1 dsc: Add version 3.2.3 Aug 31, 2026
@z-Fng

z-Fng commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

/verify

@github-actions

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

dsc

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@z-Fng
z-Fng merged commit d02b0b8 into ScoopInstaller:master Aug 31, 2026
3 checks passed
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: dsc

2 participants