hongdown: Add version 0.4.3#18004
Conversation
📝 WalkthroughWalkthroughThis PR adds a new package manifest file Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
bucket/hongdown.json (1)
1-28: Run the standard local manifest checks before submission.Use the required Scoop workflow for
hongdown:scoop config debug true scoop config gh_token <your-github-token> # optional, read-only .\bin\checkver.ps1 -App hongdown -f .\bin\formatjson.ps1 -App hongdown scoop install bucket/hongdown.json -a 64bit scoop install bucket/hongdown.json -a arm64Reference docs:
- https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md
- https://github.com/ScoopInstaller/Scoop/wiki/App-Manifests
As per coding guidelines, provide clear instructions for
checkver,formatjson, and per-architecture install testing for new manifests.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@bucket/hongdown.json` around lines 1 - 28, Run the standard local manifest checks for hongdown.json: enable debug and (optionally) set GH token, then run .\bin\checkver.ps1 -App hongdown -f to validate the "checkver" field and release detection, run .\bin\formatjson.ps1 -App hongdown to enforce manifest formatting (verifying "version", "architecture", "autoupdate" and "bin" fields), and perform per-architecture installs using scoop install bucket/hongdown.json -a 64bit and -a arm64 to validate the provided URLs/hashes in the "architecture" block; if any step fails, update hongdown.json (fields: "version", "architecture.*.url", "architecture.*.hash", "autoupdate") to correct the values and re-run the checks.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@bucket/hongdown.json`:
- Around line 1-28: This new manifest (hongdown.json) lacks a linked
package-request issue; please create a package-request using the provided
template URL and then add the issue link to the manifest's "description" field
or the PR body and confirm the acceptance criteria (well-known usage, stable
release, English interface/docs). Use the package-request template URL from the
review, paste the created issue URL into the description value of hongdown.json
(or top of the PR body), and include a short note stating the manifest meets the
three checks so reviewers can verify.
---
Nitpick comments:
In `@bucket/hongdown.json`:
- Around line 1-28: Run the standard local manifest checks for hongdown.json:
enable debug and (optionally) set GH token, then run .\bin\checkver.ps1 -App
hongdown -f to validate the "checkver" field and release detection, run
.\bin\formatjson.ps1 -App hongdown to enforce manifest formatting (verifying
"version", "architecture", "autoupdate" and "bin" fields), and perform
per-architecture installs using scoop install bucket/hongdown.json -a 64bit and
-a arm64 to validate the provided URLs/hashes in the "architecture" block; if
any step fails, update hongdown.json (fields: "version", "architecture.*.url",
"architecture.*.hash", "autoupdate") to correct the values and re-run the
checks.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: adc9f2e9-9f99-40fb-9e0b-f8de203c09f2
📒 Files selected for processing (1)
bucket/hongdown.json
|
/verify |
|
All changes look good. Wait for review from human collaborators. hongdown
|
Closes #18005.
<manifest-name[@version]|chore>: <general summary of the pull request>