Make netCDF4 optional on Emscripten/WASM#2
Merged
Conversation
netCDF4 is a compiled extension with no Pyodide wheel, so requiring it unconditionally makes PyISTP (and anything depending on it, e.g. Speasy) uninstallable under WASM. Mark it `; sys_platform != "emscripten"` so micropip skips it there. The netCDF driver is already imported lazily (only when a netCDF/HDF file is actually read), so `import pyistp` keeps working without netCDF4; CDF support via pycdfpp is unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
netCDF4is a compiled extension with no Pyodide wheel, so the unconditional'netCDF4'dependency (added in 0.8.0) makes PyISTP — and anything that depends on it, like Speasy — fail to install under WASM/Pyodide (micropiperrors with Can't find a pure Python 3 wheel for 'netcdf4').Mark it
netCDF4; sys_platform != "emscripten"so micropip skips it on WASM. The netCDF driver is already imported lazily (only inside_driver_factory, when a netCDF/HDF file is actually read), soimport pyistpkeeps working without netCDF4; CDF support viapycdfppis unaffected.Needs a release (0.8.1) for Speasy's WASM CI to pick it up.
🤖 Generated with Claude Code