Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OptimizationNOMAD translated every nonlinear constraint as
c(x) - ucons <= 0, so lower bounds were not passed to NOMAD. A lower-only constraint such as1 <= xbecamex - Inf <= 0and therefore accepted every finite value.This change represents each interval constraint as:
That enforces both sides while preserving upper-only constraints and reducing equality constraints to an absolute residual.
Reproduction
The added regression minimizes
x^2with1 <= x. Before the production change, NOMAD returnedx = -0.0007, and the new assertion failed (4 passed, 1 failed). With the fix, it returns a value at the lower boundary and all Core tests pass.Tests
OPTIMIZATION_TEST_GROUP=Core julia --project=lib/OptimizationNOMAD -e 'using Pkg; Pkg.test()'— 5 passedOPTIMIZATION_TEST_GROUP=QA julia --project=lib/OptimizationNOMAD -e 'using Pkg; Pkg.test()'— 17 passed, 2 brokenjulia -e 'using Runic; exit(Runic.main(["--check", "lib/OptimizationNOMAD/src/OptimizationNOMAD.jl", "lib/OptimizationNOMAD/test/core_tests.jl"]))'— passedgit diff --check— passed