Skip to content

Remove Core.Box captures from the unconstrained OptimizationLBFGSB __solve path #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisRackauckas merged 1 commit into from
Oct 16, 2026
Merged

Remove Core.Box captures from the unconstrained OptimizationLBFGSB __solve path #1402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions lib/OptimizationLBFGSB/src/OptimizationLBFGSB.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@ end
function SciMLBase.__solve(cache::OptimizationCache{O}) where {O <: LBFGSB}
maxiters = OptimizationBase._check_and_convert_maxiters(cache.solver_args.maxiters)

local x

solver_kwargs = __map_optimizer_args(cache, cache.opt; maxiters, cache.solver_args...)

if !isnothing(cache.f.cons)
Expand Down Expand Up @@ -220,12 +218,12 @@ function SciMLBase.__solve(cache::OptimizationCache{O}) where {O <: LBFGSB}
stats = stats, retcode = opt_ret
)
else
iter_count = Ref(0)
ub_iter_count = Ref(0)
encountered_inf_nan = Ref(false)

_loss = function (θ)
ub_loss = function (θ)
x = cache.f(θ, cache.p)
iter_count[] += 1
ub_iter_count[] += 1
# Track if we encounter Inf/NaN values in the objective
if !isfinite(x[1])
encountered_inf_nan[] = true
Expand Down Expand Up @@ -267,7 +265,7 @@ function SciMLBase.__solve(cache::OptimizationCache{O}) where {O <: LBFGSB}
t0 = time()

res = optimizer(
_loss, _grad!, cache.u0, bounds; m = cache.opt.m, solver_kwargs...
ub_loss, _grad!, cache.u0, bounds; m = cache.opt.m, solver_kwargs...
)

# Extract the task message from the result
Expand Down
11 changes: 11 additions & 0 deletions lib/OptimizationLBFGSB/test/core_tests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,4 +95,15 @@ import SciMLBase
@test res_safe.u[1] < 0.0
@test res_safe.u[1] > -0.5
end

# Regression: unconstrained LBFGSB path must not box `x` / dual-branch
# `iter_count`/`_loss` into Core.Box (dynamic dispatch on every eval).
@testset "no Core.Box in unconstrained LBFGSB __solve" begin
optf_box = OptimizationFunction(rosenbrock, OptimizationBase.AutoForwardDiff())
prob_box = OptimizationProblem(optf_box, zeros(2))
cache_box = init(prob_box, OptimizationLBFGSB.LBFGSB())
src = only(code_typed(SciMLBase.__solve, (typeof(cache_box),)))[1]
nboxes = count(t -> t === Core.Box, something(src.ssavaluetypes, []))
@test nboxes == 0
end
end
Loading