Retry transient bibliography and website HTTP failures - #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metadata installer and website smoke test currently fail on a single connection timeout. The bibliography endpoint is a read-only lookup even though it uses POST, so a transient failure can safely be retried.
Keep the existing 30-second request timeout and allow at most three attempts, with 1- and 2-second backoff. Retry connection failures, interrupted responses, and HTTP 408/429/500/502/503/504. Fail immediately on other HTTP errors, certificate verification errors, or invalid JSON. Bibliography validation still happens before any files are changed. Use HTTPS directly for the website smoke test.
Validation: 32 offline tests passed, including recovery, exhaustion, permanent errors, and no writes on failure. All 10 live website and metadata tests passed against the deployed endpoint. Black and isort checks passed. No CGI/server change or deployment is required.
Follow-up for the live HTTP failures in RussTedrake/manipulation#579.
This change is