Repository navigation
fix(fuselage): Stop clipping the SplitButton focus ring - #2299
Merged
Merged
Conversation
The group clipped its children to round the corners, which also cut off the focus ring drawn outside each segment, leaving only a sliver over the adjacent one. The outer corners are now rounded on the first and last segments instead.
|
juliajforesti
approved these changes
Oct 9, 2026
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
SplitButtonrounded its corners withoverflow: hiddenon the group, which also clipped the focus ring each segment draws outside its box: a focused segment only showed a sliver of the ring over the adjacent segment (inherited from the oldButtonGroupjoinedvariant).The group no longer clips; the outer corners are rounded on the first and last segments instead (logical properties, so RTL keeps working). The resting look is unchanged — the existing SplitButton visual baselines pass as-is.
Issue(s)
Seen while adopting
SplitButtonin the Rocket.Chat call controls (RocketChat/Rocket.Chat#42663).Further comments
SplitButtonhas not been released yet (#2274), so this is aregressionwith no changeset.