Skip to content

fix(fuselage): Stop clipping the SplitButton focus ring - #2299

Merged
ggazzo merged 1 commit into
mainfrom
regression/split-button-focus-ring
Oct 9, 2026
Merged

ggazzo merged 1 commit into
mainfrom
regression/split-button-focus-ring

Conversation

@ggazzo

@ggazzo ggazzo commented Oct 9, 2026

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

SplitButton rounded its corners with overflow: hidden on the group, which also clipped the focus ring each segment draws outside its box: a focused segment only showed a sliver of the ring over the adjacent segment (inherited from the old ButtonGroup joined variant).

The group no longer clips; the outer corners are rounded on the first and last segments instead (logical properties, so RTL keeps working). The resting look is unchanged — the existing SplitButton visual baselines pass as-is.

Trigger focused Action focused
Full ring around the menu segment Full ring around the action segment

Issue(s)

Seen while adopting SplitButton in the Rocket.Chat call controls (RocketChat/Rocket.Chat#42663).

Further comments

SplitButton has not been released yet (#2274), so this is a regression with no changeset.

The group clipped its children to round the corners, which also cut off the focus ring drawn outside each segment, leaving only a sliver over the adjacent one. The outer corners are now rounded on the first and last segments instead.
@changeset-bot

changeset-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c7175d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@juliajforesti juliajforesti changed the title regression(fuselage): Stop clipping the SplitButton focus ring fix(fuselage): Stop clipping the SplitButton focus ring Oct 9, 2026
@mergify

mergify Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@ggazzo
ggazzo merged commit 693f6ad into main Oct 9, 2026
8 of 9 checks passed
@ggazzo
ggazzo deleted the regression/split-button-focus-ring branch October 9, 2026 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants