Repository navigation
fix(fuselage-forms): synchronize dynamic field labels - #2270
Closed
YashAnand69 wants to merge 2 commits into
Closed
YashAnand69 wants to merge 2 commits into
YashAnand69 wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: f32eb9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
Closing this fix as obsolete after #2303 removed the fuselage-forms package. Resolving the conflict by restoring FieldContext would undo that removal. The tested branch is retained for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Keep a wrapped input's accessible name in sync when its visible FieldLabel text changes. Observe label text and child updates, and disconnect the observer and clear the copied name when the label detaches.
Issue(s)
Closes #2269.
Further comments
Two accessibility regressions fail before the change: updated text and removed label. All 3 form suites / 44 tests / 14 snapshots pass afterward; package lint, formatting, TypeScript and whitespace checks pass. The observer is limited to the label subtree. This is independent of #2262, which handles click-action unsubscription in a different hook. No visual styling changes; browser visual regression was not run. Includes a patch changeset. Developed with AI assistance and validated locally.