Repository navigation
"Banner not found" #42489
Description
Activity
Hi! I'm an engineering student and GSoC applicant looking for a good first issue, and I would love to tackle this one.
It looks like the banners.dismiss endpoint/method is throwing a banner-not-found error behind the scenes. It seems the backend is strictly validating the banner against the global Banners collection, but failing because the 'new version' notice is a user-specific system banner. I plan to update the backend logic in apps/meteor to correctly validate and mark these user-level banners as dismissed without throwing an error.
Could you assign this to me?
I have solved the issue on my end and will make a PR soon.
im on it
Description:
When I close the banner "Update your Rocket.Chat New version available (8.8.1)" there is a message :And the banner come back again and again, every time I open the app.
PS : My app is already updated
Steps to reproduce:
Expected behavior:
Close the banner and the banner be close for good, forever.Actual behavior:
The banner come back again and again...