feat: add variant override - #114
Conversation
|
Non blocking, but personally I would find more convenient if the variant override could be specified in pkg_additonal_info yaml file. |
|
ChatGPT made a good point:
|
|
yes, that is indeed true. Meaning it would not work well in PR builds, unfortunately. But in the package builds we can add |
Exactly, PR builds and local builds done via |
|
Ok, I see two ways forward:
|
|
I probably prefer O2, or at least I would know how to implement O2. |
|
O2 sounds good - we don’t have any old style recipes anymore, do we? |
|
Hi @wolfv - quick follow up here :) |
|
Another ping @wolfv |
|
One more ping @ruben-arts @wolfv |
Address review feedback: variant overrides are now specified per-package in pkg_additional_info.yaml instead of vinca.yaml, keeping all per-package config in one place. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ec3f516 to
7667fb4
Compare
|
Updated and rebased this PR. I implemented O2 from the discussion:
Local tests/lint/format pass, and CI is green on Linux, macOS, and Windows. |
Adds variant overrides that would add a
variants.yamlfile upon generation.I think we might have to change some GHA template files in the repositories to make it work.