docs(taxonomy): correct resync module's account of its own callers - #946
Merged
Conversation
The module docstring described an admin CLI surface (`just admin … taxonomy resync`) and an auto-propagate-on-publish hook as if they wrapped `resync_tenant` / `resync_all_tenants`. Neither exists — there is no `taxonomy` group under `robosystems/admin/commands/`, and both wrappers have zero callers. What actually propagates library content to provisioned tenants is the lower-level `resync_library_into_tenant`, invoked directly from extensions migrations 0022 (seed rs-metric), 0023 (grow rs-metric in place) and 0024 (seed rs-driver), each fanning one package-pinned resync across `for_each_tenant_schema` under the 0016 GUC bypass. Two consequences worth recording next to the code, since both were mis-read from the docstring: the propagation machinery is proven rather than unbuilt, and because every migration so far pinned a single package, rs-gaap core has never been re-propagated to a provisioned tenant. Docstring only — no behavior change. The wrappers are kept deliberately as the seam for a future operator entrypoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docstring-only correction to
robosystems/operations/taxonomy_block/resync.py. No behavior change.The module docstring claimed an admin CLI surface (
just admin … taxonomy resync) and an auto-propagate-on-publish hook wrappedresync_tenant/resync_all_tenants. Neither exists — there is notaxonomygroup underrobosystems/admin/commands/, and both wrappers have zero callers.What actually propagates
resync_library_into_tenant— the lower-level function — called directly from extensions migrations:0022_metricsrs-metric0023_metrics_m2rs-metric0024_forecastrs-driverEach reseeds
publicfrom the baked JSON-LD artifact via 0002's three seed passes, then fans a package-pinned resync acrossfor_each_tenant_schemaunder the 0016SET LOCAL robosystems.library_resyncGUC.Why it's worth a commit
Both facts were mis-read straight from the docstring during a planning pass:
0023.The wrappers are kept deliberately — they remain the intended seam for a future operator entrypoint (a Dagster job; an admin CLI is unsuitable here because
just adminruns on the host and the reseed reads the artifact from disk, so a prod invocation would seed the sharedpubliclibrary from the operator's local checkout).Test plan
uv run ruff check— cleanuv run ruff format --check— clean🤖 Generated with Claude Code