Skip to content

docs(taxonomy): correct resync module's account of its own callers - #946

Merged
jfrench9 merged 1 commit into
mainfrom
chore/resync-docstring-accuracy
Jul 28, 2026
Merged

docs(taxonomy): correct resync module's account of its own callers#946
jfrench9 merged 1 commit into
mainfrom
chore/resync-docstring-accuracy

Conversation

@jfrench9

Copy link
Copy Markdown
Member

Summary

Docstring-only correction to robosystems/operations/taxonomy_block/resync.py. No behavior change.

The module docstring claimed an admin CLI surface (just admin … taxonomy resync) and an auto-propagate-on-publish hook wrapped resync_tenant / resync_all_tenants. Neither exists — there is no taxonomy group under robosystems/admin/commands/, and both wrappers have zero callers.

What actually propagates

resync_library_into_tenant — the lower-level function — called directly from extensions migrations:

Migration Package Note
0022_metrics rs-metric initial seed
0023_metrics_m2 rs-metric grown in place — the amend path, not just additive
0024_forecast rs-driver initial seed

Each reseeds public from the baked JSON-LD artifact via 0002's three seed passes, then fans a package-pinned resync across for_each_tenant_schema under the 0016 SET LOCAL robosystems.library_resync GUC.

Why it's worth a commit

Both facts were mis-read straight from the docstring during a planning pass:

  1. The propagation machinery is proven in production, not unbuilt-and-unused — so a taxonomy change ships to tenants today by authoring a migration modeled on 0023.
  2. Because every migration so far pinned a single package, rs-gaap core has never been re-propagated to a provisioned tenant. That is the real remaining gap, and it wasn't visible from the code's own description of itself.

The wrappers are kept deliberately — they remain the intended seam for a future operator entrypoint (a Dagster job; an admin CLI is unsuitable here because just admin runs on the host and the reseed reads the artifact from disk, so a prod invocation would seed the shared public library from the operator's local checkout).

Test plan

  • uv run ruff check — clean
  • uv run ruff format --check — clean
  • No executable lines touched; diff is entirely within the module docstring

🤖 Generated with Claude Code

The module docstring described an admin CLI surface
(`just admin … taxonomy resync`) and an auto-propagate-on-publish hook as
if they wrapped `resync_tenant` / `resync_all_tenants`. Neither exists —
there is no `taxonomy` group under `robosystems/admin/commands/`, and both
wrappers have zero callers.

What actually propagates library content to provisioned tenants is the
lower-level `resync_library_into_tenant`, invoked directly from extensions
migrations 0022 (seed rs-metric), 0023 (grow rs-metric in place) and 0024
(seed rs-driver), each fanning one package-pinned resync across
`for_each_tenant_schema` under the 0016 GUC bypass.

Two consequences worth recording next to the code, since both were
mis-read from the docstring: the propagation machinery is proven rather
than unbuilt, and because every migration so far pinned a single package,
rs-gaap core has never been re-propagated to a provisioned tenant.

Docstring only — no behavior change. The wrappers are kept deliberately as
the seam for a future operator entrypoint.
@jfrench9
jfrench9 merged commit e309e22 into main Jul 28, 2026
6 checks passed
@jfrench9
jfrench9 deleted the chore/resync-docstring-accuracy branch July 28, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant