Add --puby-verbose and hide noisy informational messages - #15
Merged
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
Pull request overview
This PR introduces a new --puby-verbose flag that enables additional puby-specific logging while keeping delegated command arguments clean, and it reduces default console noise by hiding engine override and project-skip informational messages unless explicitly requested.
Changes:
- Add
--puby-verboseparsing onCommandand expose it viaCommand.verbose. - Gate engine override + project skipping/exclusion messages behind
--puby-verbose. - Update help text, README, changelog, and adjust tests that assert on skip output.
Reviewed changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
lib/command.dart |
Parses --puby-verbose (stripped from delegated args) and exposes Command.verbose. |
bin/projects.dart |
Hides engine override + skip/exclusion informational messages unless command.verbose is set. |
bin/link.dart |
Hides “Skipping workspace member” output unless command.verbose is set. |
bin/puby.dart |
Documents --puby-verbose in CLI help text. |
README.md |
Adds a brief note documenting --puby-verbose. |
CHANGELOG.md |
Adds a 1.39.0 entry describing the new flag and reduced default noise. |
test/pub_test.dart |
Updates test invocations to include --puby-verbose where skip output is asserted. |
test/link_test.dart |
Updates workspace-member skip-output test to include --puby-verbose. |
test/run_test.dart |
Updates test invocation to include --puby-verbose for skip assertions. |
test/gen_test.dart |
Updates test invocation to include --puby-verbose for skip assertions. |
test/config_test.dart |
Updates test invocation to include --puby-verbose for skip assertions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--puby-verbosefor more detailed puby output (stripped from delegated command args, unlike--verbose)Test plan
puby getin a monorepo and confirm skip/override messages are hiddenpuby get --puby-verboseand confirm those messages appearpuby get --verbosestill forwards--verboseto pub/flutterpuby linkstill prints per-project resolve/download lines without--puby-verbosedart test)