Port to AdwShortcutsDialog#116
Open
Wartybix wants to merge 2 commits into
Open
Conversation
Revisto
requested changes
Jul 15, 2026
Revisto
left a comment
Revisto
left a comment
Owner
There was a problem hiding this comment.
Hi, thanks for the PR,
now that we are changing this, lets make it a bit cleaner.
we can drop the accelerator: props, the keys are already set on the actions via set_accels_for_action, and Adw.ShortcutsItem pulls them from action-name. keeping both is duplicate.
we can make section titles shorter, for example by dropping “Controls” / “Management” (Playback Controls -> Playback). also we can group related items under one titled section instead of splitting volume/mute/export into tiny untitled ones.
i have something like this in mind:
- General -> Show Shortcuts, Quit
- Playback -> Play/Pause, Clear All
- BPM & Volume -> inc/dec bpm, inc/dec volume, mute
- Pattern -> load, save, export
- Navigation -> go to instrument, prev/next page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports the deprecated GtkShortcutsWindow to the newer AdwShortcutsDialog 😁.
Also, I updated the GNOME runtime version to 49 in the Flatpak manifest (and updated numpy dependencies so that Drum Machine compiles with the new runtime), in order to use the libadwaita version that supports this new widget.
Type of Change