Skip to content

feat: boba network#1721

Merged
LeoSlrRf merged 5 commits intomasterfrom
feat/boba-network
Apr 24, 2026
Merged

feat: boba network#1721
LeoSlrRf merged 5 commits intomasterfrom
feat/boba-network

Conversation

@LeoSlrRf
Copy link
Copy Markdown
Contributor

@LeoSlrRf LeoSlrRf commented Apr 21, 2026

Description

Support for the boba network.

The following contracts were deployed:

  • RequestDeployer
  • ERC20Proxy
  • ERC20FeeProxy
  • EthProxy
  • EthFeeProxy
  • BatchConversionPayments

All verified on https://bobascan.com/

Comments to reviewers:

Contracts' addresses are different from the previous deployment due to a different compiler configuration.
Also mocked the getLogs calls in integration tests. They were hitting pubic RPC causing flakiness.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 21, 2026

Greptile Summary

This PR adds support for the Boba network (chain ID 288) across the request-network monorepo, deploying ERC20Proxy, ERC20FeeProxy, EthProxy, EthFeeProxy, BatchConversionPayments, and RequestDeployer contracts. The integration follows the exact same pattern as recently added networks (e.g., sonic) and includes a useful defensive change to setupBatchConversionPayments.ts that skips proxies missing a deployment instead of failing the entire setup.

Confidence Score: 5/5

This PR is safe to merge — it is a straightforward network integration with no logic changes, only additive configuration and contract address registrations.

All changes follow the exact established pattern for previously added networks (e.g., sonic). The defensive try/catch in setupBatchConversionPayments.ts is a clean improvement that gracefully handles the known absence of conversion proxies on Boba. No existing behaviour is modified, only new entries are added across config and artifact files. No P0 or P1 issues found.

No files require special attention.

Important Files Changed

Filename Overview
packages/currency/src/chains/evm/data/boba.ts New chain definition file — exports chainId 288, consistent with other minimal chain files (e.g., sonic.ts).
packages/currency/src/chains/evm/index.ts Imports and registers the new BobaDefinition in the chains record, following the alphabetical pattern.
packages/currency/src/native.ts Adds ETH-boba native currency entry (18 decimals) to the ETH currency list.
packages/payment-detection/src/eth/multichainExplorerApiProvider.ts Adds boba to the networks map and routes to the routescan.io Etherscan-compatible API (matches hardhat.config.ts).
packages/smart-contracts/hardhat.config.ts Adds boba network (chainId 288) to Hardhat network config, Etherscan verifier, and xdeploy networks list.
packages/smart-contracts/scripts-create2/contract-setup/setupBatchConversionPayments.ts Wraps each proxy update in a try/catch so deployments missing on boba (ETHConversion, ERC20Conversion, chainlinkConversionPath) are skipped gracefully rather than halting the entire setup.
packages/smart-contracts/src/lib/artifacts/BatchConversionPayments/index.ts Adds boba contract address and creation block; comment correctly notes missing conversion proxies.
packages/types/src/currency-types.ts Adds 'boba' to the EvmChainName union type, keeping alphabetical order.
packages/utils/src/providers.ts Adds boba RPC URL https://mainnet.boba.network to the networkRpcs map.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Boba Network\nchainId: 288] --> B[Currency Layer]
    A --> C[Smart Contracts]
    A --> D[Payment Detection]
    A --> E[Utils / Providers]

    B --> B1[boba.ts\nchainId = 288]
    B --> B2[native.ts\nETH-boba]
    B --> B3[currency-types.ts\nEvmChainName union]

    C --> C1[RequestDeployer\n0xE99A...24B2]
    C --> C2[ERC20Proxy\n0x5079...d72]
    C --> C3[ERC20FeeProxy\n0x8881...BeE7]
    C --> C4[EthereumProxy\n0xba25...dfBA]
    C --> C5[EthereumFeeProxy\n0xe456...a6eF]
    C --> C6[BatchConversionPayments\n0xD830...7C76\nno conversion proxies]

    D --> D1[multichainExplorerApiProvider\nroutescan.io API]

    E --> E1[providers.ts\nhttps://mainnet.boba.network]
Loading

Reviews (1): Last reviewed commit: "update all packages" | Re-trigger Greptile

@LeoSlrRf LeoSlrRf requested a review from MantisClone April 22, 2026 08:21
Comment thread packages/request-client.js/test/index.test.ts
@LeoSlrRf LeoSlrRf requested review from dave-rf and speshov-rf April 22, 2026 11:32
@LeoSlrRf LeoSlrRf merged commit f0eff82 into master Apr 24, 2026
12 checks passed
@LeoSlrRf LeoSlrRf deleted the feat/boba-network branch April 24, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants