Variable item definitions, and a flatter loot table item

[bitwit]

Two pieces, both driven by moving game data to CSV.

1. A variable-item descriptor bound to RP.Stats

@StatsStruct now synthesizes a nested ItemDefinition alongside dynamicKeys: one String? per stat, plus code / displayName / tags / equipmentSlotCode / maxNumberOfOptionalStats / metadata. Both come from the same list of stored properties, so the descriptor and the stat keys cannot drift — adding a stat makes its CSV column understood with no other edit. It's generic over Metadata rather than taking a macro argument, so @StatsStruct keeps its no-argument form.

RPCache.loadItemDefinitions parses the cells and fills the item cache and the new lootTableItems cache. A cell's ! means always applies:

Cell	Lands as
1!	fixed stat on the RPItem — nothing to vary
5-10!	requiredVariations, 5...10
5	optionalVariations, 5...5
1-2	optionalVariations, 1...2

An unknown stat key throws rather than being silently dropped.

Ranges needed no new type in the loot model: RPFragmentVariation already had base stats plus a variableStats ceiling rolled 0...ceiling and added on, so 5-10 is base 5 with ceiling 5, and a degenerate 5...5 is base 5 with a nil ceiling so the roll is skipped entirely. RPItemDefinitionStatVariation exists only at the parsing seam.

2. RPLootTableItem loses Kind

Kind (.fixed/.variant) and RPLootVariation are gone, replaced by requiredVariations, optionalVariations and maxNumberOfOptionalStats. An entry with neither array is implicitly fixed, via initializer defaults. One variation per stat cell, so the cap counts stats and fragments interchangeably — resolving the ambiguity maximumFragments had.

Required variations bypass both the chance roll and the cap. Optionals are now drawn as a uniform random subset rather than a declaration-order prefix; a failed chance roll still doesn't consume the cap. No shipping data carried a variation block, so there was nothing to migrate.

Test target restored

Tests/ had not compiled since f564c0d removed the RPSpaceDictionary protocol TestRPSpace conformed to — the same commit that added loot tables — so nothing in RPTrunk had run since. Restoring the conformance (dictionary-backed storage methods, cache, CodingKeys to keep cache out of Codable) brings the suite back, and adds a randomRule hook beside chanceRule so the optional draw is deterministic.

Verification

swift test — 150 tests, 1 failure. The failure is BodyTests.test_global_cooldown_gates_actions_even_when_the_ability_is_ready, pre-existing and newly visible rather than newly broken; logged in known-issues.md.

13 of those are new, covering cell parsing, the fixed/required/optional routing, an unknown key throwing, and the roll. The two that pin which stat lands in which optional variation and its bounds were verified by mutation: reversing the key iteration order and always emitting a ceiling each turn them red, and the ceiling mutation is caught by nothing else in the suite.

Downstream

dungeon-cleaners#equipment-loot consumes this by local path and must land together — it uses RoleplayingStats.ItemDefinition and loadItemDefinitions.

🤖 Generated with Claude Code

[bitwit]

global cooldown deliberately prevents any other action until it is complete

[bitwit]

Fixed - this was a stale magic number, not a design question. The test hardcoded 2500ms but RPBody.globalCooldown defaults to 500. Now reads rpSpace.bodies[body.id]!.globalCooldown instead of the literal, so it ticks cooldown - 1 then 1 regardless of what the default is. 150/150 green in 1dff6b5, and the known-issues.md entry is removed since it's no longer open.

[bitwit]

I've dicided to reverse things where a "?" at the end means optional and if not its required. It feels like a more natural way to express it and more consistent with swift anyway.

[bitwit]

Flipped in 1dff6b5 - isRequired now defaults to true, and a trailing ? sets it false. Only init(parsing:) changed; everything downstream (RPCache+ItemDefinitions.swift, the routing switch) reads isRequired/isFixed and never touched the symbol, so the flip was contained to one file plus its tests.