Skip to content

use pytest in CI, and exclude tests from coverage again#301

Merged
joanise merged 4 commits intomainfrom
dev.ej/pytest-ci
Apr 28, 2026
Merged

use pytest in CI, and exclude tests from coverage again#301
joanise merged 4 commits intomainfrom
dev.ej/pytest-ci

Conversation

@joanise
Copy link
Copy Markdown
Member

@joanise joanise commented Apr 21, 2026

PR Goal?

In previous refactorings, we accidentally started counting coverage of tests/* again. Reconfigure that out.

And let's use pytest in CI too, it's now required and the default, so we can start embracing it.

Confidence?

high

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Apr 21, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  tests/test_anchors.py  48% smaller
  tests/test_audio.py  48% smaller
  tests/test_make_xml_cli.py  48% smaller
  tests/test_smil.py  48% smaller
  tests/test_tokenize_cli.py  48% smaller
  tests/test_dna_utils.py  48% smaller
  tests/test_force_align.py  23% smaller
  tests/test_temp_file.py  17% smaller
  .github/workflows/tests.yml  11% smaller
  run_tests.py  10% smaller
  .github/workflows/matrix-tests.yml  0% smaller
  README.md Unsupported file format
  pyproject.toml Unsupported file format
  tests/.coveragerc Unsupported file format
  tests/test_align_cli.py  0% smaller
  tests/test_api.py  0% smaller
  tests/test_config.py  0% smaller
  tests/test_dna_text.py  0% smaller
  tests/test_dtd.py  0% smaller
  tests/test_g2p_cli.py  0% smaller
  tests/test_misc.py  0% smaller
  tests/test_package_urls.py  0% smaller
  tests/test_silence.py  0% smaller
  tests/test_tokenize_xml.py  0% smaller
  tests/test_web_api.py  0% smaller

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.77%. Comparing base (f9dedee) to head (0779eb6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   95.20%   92.77%   -2.44%     
==========================================
  Files          43       21      -22     
  Lines        3674     1800    -1874     
  Branches        0      295     +295     
==========================================
- Hits         3498     1670    -1828     
+ Misses        176       93      -83     
- Partials        0       37      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

CLI load time: 0:00.05
Pull Request HEAD: 0779eb63d7a210886993b5dc9e877185668d530a
No imports take more than 0.1 s.

@joanise
Copy link
Copy Markdown
Member Author

joanise commented Apr 21, 2026

@dhdaines Adding you to reviewers here because you might be happy to see the move fully to pytest, in CI, in run_tests.py, everywhere.

I have not started using fixtures for Studio, but I have one fixture in g2p (to launch g2p_studio). A number of tests in Studio could be simplified with fixtures, but that's going to stay lower priority at the moment.

@joanise joanise changed the base branch from dev.ej/picky-coding to main April 23, 2026 15:57
@joanise joanise requested a review from roedoejet April 27, 2026 21:31
Copy link
Copy Markdown
Collaborator

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good improvement to me. thanks @joanise

Comment thread run_tests.py
requested_list = list(list_tests(suite))

SUITES = {
"all": [], # relies on discovery to collect all tests
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, this is nice

@joanise joanise merged commit d72a390 into main Apr 28, 2026
28 of 29 checks passed
@joanise joanise deleted the dev.ej/pytest-ci branch April 28, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants