Repository navigation
Address the review in #9: improper log scales, a new-scheme tutorial, docs - #11
Merged
Merged
Conversation
… docs - `logscale = improper` declares a message rule whose message has no normalising constant, as an exact message may (the likelihood of a variance integrates to infinity): its log scale is an UndefinedLogScale with cause `:improper`, and require_logscale says that none exists, where an omitted `logscale` says that it is not known. - A tutorial, "A new message passing scheme": natural-gradient message passing for a Poisson count with a log rate, as an algorithm, a dependency declaration and a rule, iterated to its fixed point; it cites Lukashchuk et al., Information Geometry of Message Passing (2026). - What the registry is for, with an example; "resolution" defined in the glossary and linked from each page; purity explained by what a pure rule may and may not do; improper messages on the Log scales page and in the glossary; a shorter first example on the overview; the expectation propagation entry pointing to the tutorial that builds such a rule; the default-scheme example told through its own node; the first tutorial's opening reworded. - A Makefile: test (as CI runs it, with test_args), test-fast, docs, docs-serve (LiveServer in the docs environment), format, check-format, clean. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
A RuleResult shows a log scale's source only when the log scale is a number, and an improper rule's is always an UndefinedLogScale, so the method never ran (Codecov's patch check). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #9. Each point of the review, and what this changes:
registered_rules,rule_coverageand aRuleNotFoundError's near misses all read its registry, while resolution, Julia's dispatch, never does. TheRegistrydocstring points to it.ispureand Algorithms and dependencies now list what a pure rule may do (allocate, write the output buffer it is handed, reuse its scratch, draw fromctx.rng, warn or log) and what makes one impure (mutating an input or its algorithm, writing globals or files, carrying its own generator).make testas CI runs it (TEST_ALL=true, FastCholesky throwing on asymmetry), withtest_args="tag:… name:… <file>";test-fast,docs,docs-serve(LiveServer is now indocs/Project.toml),format,check-format,clean.Transitionnode.y ~ Poisson(exp(x))as an algorithm, a dependency declaration (the rule reads its own beliefq[:in]) and a closed-form rule, iterated to its fixed point, citing Information Geometry of Message Passing. It needs no package beyond the docs' usual ones.logscale = improper, for a message with no normalising constant, as an exact message may be: its log scale is anUndefinedLogScalewith cause:improper, andrequire_logscalesays that none exists, where an omittedlogscalesays that it is not known. The Log scales page has a section on improper messages, and the glossary qualifies the definition.improperis a new public name, so this is a minor release, 1.1.0, once approved. The suite passes locally with CI's variables, and the docs build.🤖 Generated with Claude Code