fix: repair duplicate form-constraint @warn (UndefVarError opt) - #314
Open
docxology wants to merge 1 commit into
Open
fix: repair duplicate form-constraint @warn (UndefVarError opt)#314docxology wants to merge 1 commit into
@warn (UndefVarError opt)#314docxology wants to merge 1 commit into
Conversation
The 'already has functional form constraint' warnings referenced undefined locals opt and constraint_data inside lazy"...", producing UndefVarError instead of the intended informative warning. Use bound getconstraint(...).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2. In
src/plugins/variational_constraints/variational_constraints_engine.jl, the"node already has a functional form constraint" warning (
@warn lazy"...") interpolatedundefined local variables
optandconstraint_data, raisingUndefVarError: optinsteadof producing the intended warning. Affects both the
MarginalFormConstraint(line 954) andMessageFormConstraint(line 969) paths.Change
Replace the broken interpolations with bound values:
and for the message path (line 969) the analogous fix using
getconstraint(message_constraint).Tests
Added a regression test that pre-sets
VariationalConstraintsMarginalFormConstraintKey(andVariationalConstraintsMessagesFormConstraintKey) on a node, applies a second formconstraint, and asserts (a) a warning is emitted and (b) the original constraint is preserved.
Verification
test/plugins/variational_constraints/variational_constraints_engine_tests.jl: passtest/plugins/variational_constraints/variational_constraints_tests.jl: passCloses #305